Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add checks to ERC7579Utils.decodeBatch #5353

Merged
merged 28 commits into from
Dec 12, 2024
Merged

Add checks to ERC7579Utils.decodeBatch #5353

merged 28 commits into from
Dec 12, 2024

Conversation

Amxx
Copy link
Collaborator

@Amxx Amxx commented Dec 10, 2024 •
edited
Loading

PR Checklist

  • Tests
  • Documentation
  • Changeset entry (run npx changeset add)

@Amxx Amxx added the bug label Dec 10, 2024
@Amxx Amxx added this to the 5.2-after-freeze milestone Dec 10, 2024
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Dec 10, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 4d137e0

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@Amxx Amxx changed the title Add checks to decodeBatch Add checks to ERC7579Utils.decodeBatch Dec 10, 2024
@Amxx Amxx requested review from frangio and a team December 11, 2024 11:53
frangio
frangio previously approved these changes Dec 12, 2024
View reviewed changes
frangio
frangio previously approved these changes Dec 12, 2024
View reviewed changes
@Amxx Amxx mentioned this pull request Dec 12, 2024
Merged
3 tasks
@ernestognw ernestognw merged commit 77d4a73 into OpenZeppelin:master Dec 12, 2024
17 checks passed
@Amxx Amxx deleted the fix/ERC7579-batch-decoding branch December 13, 2024 08:35
Amxx added a commit to Amxx/openzeppelin-contracts that referenced this pull request Dec 13, 2024
@Amxx @ernestognw @frangio
Add checks to ERC7579Utils.decodeBatch (OpenZeppelin#5353)
743ac45 
Co-authored-by: Ernesto García <[email protected]>
Co-authored-by: Francisco Giordano <[email protected]>
Signed-off-by: Hadrien Croubois <[email protected]>
Amxx added a commit to Amxx/openzeppelin-contracts that referenced this pull request Dec 13, 2024
@Amxx @ernestognw @frangio
Add checks to ERC7579Utils.decodeBatch (OpenZeppelin#5353)
3fa7f94 
Co-authored-by: Ernesto García <[email protected]>
Co-authored-by: Francisco Giordano <[email protected]>
Signed-off-by: Hadrien Croubois <[email protected]>
Amxx added a commit that referenced this pull request Dec 16, 2024
@Amxx @ernestognw @frangio
Cherrypick #5353 into release-v5.2 (#5367)
ab96c48 
Signed-off-by: Hadrien Croubois <[email protected]>
Co-authored-by: Ernesto García <[email protected]>
Co-authored-by: Francisco Giordano <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@19714 19714 19714 left review comments

@ernestognw ernestognw ernestognw approved these changes

@frangio frangio frangio left review comments

@adamegyed adamegyed Awaiting requested review from adamegyed

Assignees
No one assigned
Labels
bug ignore-changeset
Projects
None yet
Milestone
5.2-after-freeze
Development

Successfully merging this pull request may close these issues.
5 participants
@Amxx @frangio @adamegyed @ernestognw @19714