Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/793 - non existent pages + private workspace #862

Merged
merged 5 commits into from
Jan 18, 2024
Merged

Conversation

D-GopalKrishna
Copy link
Contributor

@D-GopalKrishna D-GopalKrishna commented Dec 25, 2023

Closes - #739, #793, and incognito mode (without token) correction.

This PR changes the blank screen with the Popup as image shown below.
Created

  • Incognito correction in Backend
  • Non Existing pages correction by adding NotFoundPages for all wrong URL and
    • Correcting ErrorBoundary for User Page error not showing
    • Showing Error for Workspace from props.error

Video describing the Incognito fix:

2023-12-26.00-01-16.mp4



Image sample:

image
image
image
image

@D-GopalKrishna
Copy link
Contributor Author

Still need to test - #739 (comment).
@filippomc - Not sure if this is related to this issue!

@filippomc filippomc merged commit ece07e4 into develop Jan 18, 2024
3 checks passed
@filippomc filippomc deleted the feature/793 branch January 18, 2024 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants