Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Warn when non-admin user tries to open private workspace #739

Closed
pgleeson opened this issue May 18, 2023 · 5 comments
Closed

Warn when non-admin user tries to open private workspace #739

pgleeson opened this issue May 18, 2023 · 5 comments
Assignees
@D-GopalKrishna
Milestone
v0.7.5

Comments

@pgleeson
Copy link
Member

pgleeson commented May 18, 2023 •
edited
Loading

All of these should give warning that workspace is private when a different non-admin user tries to open them (they just get a blank page):

https://v2.opensourcebrain.org/workspace/751
https://v2.opensourcebrain.org/workspace/open/751/nwbexplorer
https://v2.opensourcebrain.org/workspace/open/752/jupyter?resource=LoadNetPyNEData.ipynb
@pgleeson pgleeson added this to the v0.7.3 milestone May 18, 2023
@pgleeson
Copy link
Member Author

Also, even when it's my workspace, and my session has timed out, if I go to/refresh any of these that I own I don't get a warning to log in, I just see a blank page...

@pgleeson pgleeson modified the milestones: v0.7.6, v0.7.5 Nov 17, 2023
@pgleeson
Copy link
Member Author

Related to #793

D-GopalKrishna added a commit that referenced this issue Dec 25, 2023
@D-GopalKrishna
#739 incognito fix - throw 401 unauthorized without token
071f56e
@D-GopalKrishna D-GopalKrishna mentioned this issue Dec 25, 2023
Merged
@SimaoBolota-MetaCell
Copy link
Contributor

As a user with no access to the 751 workspace in dev, I am encountering the error but nothing is displayed to the user @D-GopalKrishna @filippomc

Image

@D-GopalKrishna
Copy link
Contributor

Hi @SimaoBolota-MetaCell , the PR for this issue is not yet merged! thanks!

@D-GopalKrishna
Copy link
Contributor

Hi @SimaoBolota-MetaCell , the PR for this issue is not yet merged!
here - #862

thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@D-GopalKrishna D-GopalKrishna

Labels
None yet
Projects
None yet
Milestone
v0.7.5
Development

No branches or pull requests
4 participants
@pgleeson @filippomc @D-GopalKrishna @SimaoBolota-MetaCell