Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warning/404 for non existent pages #793

Closed
pgleeson opened this issue Oct 18, 2023 · 6 comments
Closed

Warning/404 for non existent pages #793

pgleeson opened this issue Oct 18, 2023 · 6 comments
Assignees
Labels
T: bug Something isn't working
Milestone

Comments

@pgleeson
Copy link
Member

pgleeson commented Oct 18, 2023

Rather than showing a (partially) blank page e.g.
https://v2.opensourcebrain.org/jfhjgj -> should be 404
https://v2.opensourcebrain.org/workspace -> should be 404
https://v2.opensourcebrain.org/workspace/1abcd -> should be: You do not have access to a workspace with that ID
https://v2.opensourcebrain.org/user/pglee -> should be no such user

@pgleeson pgleeson added this to the v0.7.5 milestone Oct 18, 2023
@pgleeson pgleeson modified the milestones: v0.7.6, v0.7.5 Nov 17, 2023
@pgleeson pgleeson added the T: bug Something isn't working label Dec 7, 2023
@D-GopalKrishna D-GopalKrishna self-assigned this Dec 12, 2023
@D-GopalKrishna
Copy link
Contributor

D-GopalKrishna commented Dec 13, 2023

What is better?

  • a 404 page or
  • a snackbar with a message - alerting

cc @filippomc

@sanjayankur31
Copy link
Collaborator

Let's do a page, that seems cleaner?

@filippomc
Copy link
Contributor

Before the restyling, it used to be there a blank error page with a modal in the middle about the error (401, 404, or whathever else) and a button to go the homepage. I'd go for that as a catch all for any kind of issue to avoid the design of a new page. @sanjayankur31 @pgleeson what do you think?

@sanjayankur31
Copy link
Collaborator

Yeh, I think that sounds good.

@filippomc
Copy link
Contributor

Two things to configure:

  • error boundary
  • non existing pages route

@SimaoBolota-MetaCell
Copy link
Contributor

I am still getting blank pages for the following @D-GopalKrishna @filippomc

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T: bug Something isn't working
Projects
None yet
Development

No branches or pull requests

5 participants