Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tests failures when running on the host #12

Open
60 tasks
simoatze opened this issue Oct 15, 2019 · 6 comments
Open
60 tasks

Tests failures when running on the host #12

simoatze opened this issue Oct 15, 2019 · 6 comments
Assignees
@spophale
Labels
V&V bug Something in the V&V isn't working

Comments

@simoatze
Copy link
Contributor

simoatze commented Oct 15, 2019 •
edited by jhdavis8
Loading

Hi,

this may be not an actual bug. I have noticed that there are several tests which fails when executed sequentially, and that’s ok according to the spec. However, some of these tests fail when executed in parallel on the host, is that supposed to happen? In other word, where these tests written to both pass when the device is either the CPU itself or an accelerator device? Thanks!

List of tests that are failing on the host (from @tmh97)

  • test_target_teams_distribute_nowait.F90
  • test_target_teams_distribute_firstprivate.F90
  • test_target_teams_distribute_default_shared
  • test_target_enter_exit_data_set_default_device.F90
  • test_target_enter_exit_data_module_array.F90
  • test_target_enter_exit_data_devices.F90
  • test_target_enter_data_set_default_device.F90
  • test_target_enter_data_module_array.F90
  • test_target_enter_data_devices.F90
  • test_target_enter_data_components_to.F90
  • test_target_data_map_to_array_sections.F90
  • test_target_data_map_set_default_device.F90
  • test_target_data_map_devices.F90
  • test_target_data_map_components_tofrom.F90
  • test_target_data_map_components_to.F90
  • test_target_data_map_components_from.F90
  • test_target_data_map_components_default.F90
  • test_target_data_map.F90
  • test_target_data_if.F90
  • test_target_map_subroutines_arrays.F90
  • test_target_map_program_arrays.F90
  • test_target_map_module_array.F90
  • test_target_data_map_classes.cpp
  • gemv_target_reduction.cpp
  • gemv_target_many_matrices.cpp
  • test_target_update_to.c
  • test_target_update_if.c
  • test_target_update_from.c
  • test_target_update_devices.c
  • test_target_update_depend.c
  • test_target_teams_distribute_parallel_for_private.c
  • test_target_teams_distribute_parallel_for_if_parallel_modifier.c
  • test_target_teams_distribute_parallel_for_if_no_modifier.c
  • test_target_teams_distribute_parallel_for_devices.c
  • test_target_teams_distribute_shared.c
  • test_target_teams_distribute_private.c
  • test_target_teams_distribute_map.c
  • test_target_teams_distribute_lastprivate.cd
  • test_target_teams_distribute_if.c
  • test_target_teams_distribute_firstprivate.c
  • test_target_teams_distribute_device.c
  • test_target_teams_distribute_default_shared.c
  • test_target_teams_distribute_default_none.c
  • test_target_teams_distribute.c
  • test_target_enter_exit_data_struct.c
  • test_target_enter_exit_data_map_pointer_translation.c
  • test_target_enter_exit_data_map_malloced_array.c
  • test_target_enter_exit_data_map_global_array.c
  • test_target_enter_exit_data_devices.c
  • test_target_enter_exit_data_depend.c
  • test_target_data_pointer_swap.c
  • test_target_data_map_pointer_translation.c
  • test_target_data_map_devices.c
  • test_target_data_map_array_sections.c
  • test_target_data_if.c
  • test_target_map_pointer.c
  • test_target_map_struct_default.c
  • test_target_map_pointer_default.c
  • test_target_device.c
  • linked_list.c
@simoatze
Copy link
Contributor Author

Old conversion (from BitBucket):

Jose Monsalve Diaz:
Ah, yes, this has been a long debate, and we have tried to keep it host agnostic, but it has been a difficult effort. There are tests that would be impossible to run when doing it on the host (e.g. if(...) clause of target). However, we have not been diligent enough with that. Do you have the list of tests that are failing right now?

Simone Atzeni:
Jose,

thanks for your answer. I don’t have a list yet, I am working on it. As soon as I have I’ll share my findings. Maybe we can keep this issue open to discuss this further as soon as I have more info. Thanks a lot!

Jose Monsalve Diaz:
Yes, let’s do that! Thanks for your active involvement.

@josemonsalve2
Copy link
Contributor

Thanks @simoatze !

@josemonsalve2 josemonsalve2 added the V&V bug Something in the V&V isn't working label Oct 15, 2019
jhdavis8 pushed a commit that referenced this issue Nov 5, 2019
@josemonsalve2
Merged in new_test/test_target_teams_distribute_parallel_for_thread_l…
8663947 
…imit (pull request #12)

New test/test target teams distribute parallel for thread limit

* Adding test test_target_teams_distribute_parallel_for_thread_limit.c from development

* Updating summit.def file for gcc

* Updating summit.def file for gcc

* synching master ompvv/ompvv.F90

* synching master ompvv/ompvv.F90

* removing comment that is not supposed to be there

* complementing test

*  Fixing nt to tl

*  Fixing indentantion

* merging from master manually

Approved-by: Kyle Friedline <[email protected]>
Approved-by: Swaroop Pophale <[email protected]>
@tmh97
Copy link
Contributor

tmh97 commented Jan 26, 2020 •
edited
Loading

List of tests that are failing on the host

  • test_target_teams_distribute_nowait.F90
  • test_target_teams_distribute_firstprivate.F90
  • test_target_teams_distribute_default_shared
  • test_target_enter_exit_data_set_default_device.F90
  • test_target_enter_exit_data_module_array.F90
  • test_target_enter_exit_data_devices.F90
  • test_target_enter_data_set_default_device.F90
  • test_target_enter_data_module_array.F90
  • test_target_enter_data_devices.F90
  • test_target_enter_data_components_to.F90
  • test_target_data_map_to_array_sections.F90
  • test_target_data_map_set_default_device.F90
  • test_target_data_map_devices.F90
  • test_target_data_map_components_tofrom.F90
  • test_target_data_map_components_to.F90
  • test_target_data_map_components_from.F90
  • test_target_data_map_components_default.F90
  • test_target_data_map.F90
  • test_target_data_if.F90
  • test_target_map_subroutines_arrays.F90
  • test_target_map_program_arrays.F90
  • test_target_map_module_array.F90
  • test_target_data_map_classes.cpp
  • gemv_target_reduction.cpp
  • gemv_target_many_matrices.cpp
  • test_target_update_to.c
  • test_target_update_if.c
  • test_target_update_from.c
  • test_target_update_devices.c
  • test_target_update_depend.c
  • test_target_teams_distribute_parallel_for_private.c
  • test_target_teams_distribute_parallel_for_if_parallel_modifier.c
  • test_target_teams_distribute_parallel_for_if_no_modifier.c
  • test_target_teams_distribute_parallel_for_devices.c
  • test_target_teams_distribute_shared.c
  • test_target_teams_distribute_private.c
  • test_target_teams_distribute_map.c
  • test_target_teams_distribute_lastprivate.cd
  • test_target_teams_distribute_if.c
  • test_target_teams_distribute_firstprivate.c
  • test_target_teams_distribute_device.c
  • test_target_teams_distribute_default_shared.c
  • test_target_teams_distribute_default_none.c
  • test_target_teams_distribute.c
  • test_target_enter_exit_data_struct.c
  • test_target_enter_exit_data_map_pointer_translation.c
  • test_target_enter_exit_data_map_malloced_array.c
  • test_target_enter_exit_data_map_global_array.c
  • test_target_enter_exit_data_devices.c
  • test_target_enter_exit_data_depend.c
  • test_target_data_pointer_swap.c
  • test_target_data_map_pointer_translation.c
  • test_target_data_map_devices.c
  • test_target_data_map_array_sections.c
  • test_target_data_if.c
  • test_target_map_pointer.c
  • test_target_map_struct_default.c
  • test_target_map_pointer_default.c
  • test_target_device.c
  • linked_list.c

@josemonsalve2
Copy link
Contributor

Thanks @tmh97 !

@jhdavis8 jhdavis8 mentioned this issue Mar 9, 2020
Merged
@tob2 tob2 mentioned this issue Apr 18, 2020
Closed
@jhdavis8 jhdavis8 mentioned this issue May 6, 2020
Merged
@spophale spophale self-assigned this Jun 30, 2021
@andrewkallai
Copy link
Collaborator

perlmutter_no_offloading_results.zip
Here are the testsuite results for NO_OFFLOADING=1

@rjenaa
Copy link
Collaborator

rjenaa commented Aug 29, 2024 •
edited
Loading

perlmutter_no_offloading_results_excel.zip

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@spophale spophale

Labels
V&V bug Something in the V&V isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@simoatze @josemonsalve2 @spophale @tmh97 @rjenaa @andrewkallai