Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test_target_map_struct_default.c fails if run with no device present #127

Closed
tob2 opened this issue Apr 18, 2020 · 2 comments
Closed

test_target_map_struct_default.c fails if run with no device present #127

tob2 opened this issue Apr 18, 2020 · 2 comments
Assignees
Labels
V&V bug Something in the V&V isn't working

Comments

@tob2
Copy link
Collaborator

tob2 commented Apr 18, 2020

See also #12

The problem is that the two target sections use:

#pragma omp target
    if (!omp_is_initial_device()) {

Hence, the variables do not get set and one operates on uninitialized memory.

This test case does work if one removes this condition (or sets it unconditionally to true).

@tob2 tob2 added the V&V bug Something in the V&V isn't working label Apr 18, 2020
@spophale spophale assigned spophale, tmh97 and jhdavis8 and unassigned josemonsalve2 Apr 22, 2020
@spophale
Copy link
Collaborator

spophale commented Apr 22, 2020

Thanks @tob2 ! Somewhere in the development process we moved our focus completely to device offload. We will correct it for host execution.

@tmh97
Copy link
Contributor

tmh97 commented May 6, 2020

A potential solution: Replace the if (!omp_is_inital_device) within the target region with if(isOffloading). This does not immediately resolve the issue of allowing tests to run in parallel on host however #12

tmh97 added a commit that referenced this issue Jun 15, 2020
…efault.c

Addressing failing on host as per issue #127
@tmh97 tmh97 closed this as completed Jun 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
V&V bug Something in the V&V isn't working
Projects
None yet
Development

No branches or pull requests

5 participants