Remove shared env macro from target and target data tests #143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhdavis8
added
infrastructure
spophale
approved these changes
May 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is working towards fixing issue #94. In most cases this was straightfoward to fix but there are some tests which will now fail when run on the host due to changes made here. However, for all of these tests I cross-checked the list of tests already failing on the host (issue #12) and they are already there.
Also, I removed the macro from the test templates.
These changes are tested and passing on Summit.
There are also some whitespace cleanups in these tests, so I recommend hiding whitespace changes when reviewing the files.