-
Notifications
You must be signed in to change notification settings - Fork 463
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Flexible floating platforms #537
Conversation
Sorry, this massive commit will basically make Morison.f90 and related files new entries in the repo.
This reverts commit ee693b8.
An_drag now zeroed for each joint loop Added cosPhi_ref to member data (reference value of cos(Phi) at init) Draft h_c and deltal calculations for lumping external distributed HD loads Replaced time marching seabed crossing Z-valued tests with i_floor tests Added nodeInWater to calculations for end loads: F_I_End, F_IMG_End
interpolation factor (s) was incorrect because Intel compiler was applying integer math i_floor = NElements + 1 means complete member is below seabed Checking for node submergence when computing side external hydrodynamic loads
There are still conflicts which will be corrected by hand in the next commit
…persent in inputs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've spent much time on this branch developing/reviewing theory, reviewing source code, and checking verification results. I'm ready for this branch to be merged into dev.
Congrats to everyone working to get this to the finish line. It looks close! I modified the regression test scripts to compare the channels common to both the new results and the stored baseline solutions. There are a few channels in a couple of cases that don't quite match up. @jjonkman @ebranlard @andrew-platt could you comment on the differences here? For reference, I've also attached the html files containing the complete set of common channels here: plots.zip. 5MW_OC4Jckt_DLL_WTurb_WavesIrr_MGrowth5MW_OC3Trpd_DLL_WSt_WavesRegHere's a zoomed-in snapshot of the channel above. A zoomed-in snapshot of the channel above. |
It looks like we may be triggering instability in SubDyn in the fixed bottom cases. @ebranlard , should we set some of the new damping for these cases? I had left those empty when I updated the format. from the
|
The |
Regarding the high-frequency ringing in heave in the fixed-bottom r-test cases, this is because the heave damping that was previously been included in these models via AddBLin(3,3) in HydroDyn is no longer used when PotMod = 0. Instead, I would shift the AddBLin(3,3) value from HydroDyn to SubDyn, via GuyanDampMod = 2 and GuyanDampSize = 6 and setting the associated (3,3) element of the matrix. This should be changed for the OC3-monopile, OC3-tripod, and OC4-jacket models. Regarding the M1N1FDxi from the OC3-tripod test, it appears that the member outlist in HydroDyn has been changed in the updated r-test; I'm not sure why this was changed, but that is likely the culprit Best regards, |
Updated the OpenFAST regression tests:
All other cases appear to match well now, especially considering the heavy reformulations of calculations in HD and SD. |
This is now ready for merging!!!
Complete this sentence
THIS PULL REQUEST IS READY TO MERGE!!!
Feature or improvement description
This pull request adds the ability to model flexible floating platforms with multiple potential flow bodies and flexible connections. A significant rewrite of the HydroDyn Morison module and large modifications to SubDyn was required.
Impacted areas of the software
HydroDyn
SubDyn
Glue-code
Test results, if applicable
r-test baselines need updating pending final verification (current branch: f/TCF-mods-Dev)
modules/hydrodyn/hd_5MW*
floating cases using the comparable fully coupled OpenFAST regression test results.To Do
api_change.rst
with changes to the HD input filehd_OC3tripod_offshore_fixedbottom_wavesirr
case fails withdiscretization such that even with displacements, the lowest element of a member does not
become partially submerged.```
This case was revised so this no longer is an issue (heave was set to -3m which didn't make any sense for a fixed bottom case).
HydroMx
orHydroMy
terms toHydroMzi
properly. This shows as aHydroMzi
value that is larger than before in the TLP floating case.GJH 4/23/20
comments inFAST_Subs.f90
)