AD: Support UserProp linearization #612
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
E.B. reported noted that Init%OutData_AD%BladeProps(1)%NumBlNds is undefined when AD was not used.
andrew-platt
previously approved these changes
Jan 20, 2021
|
@bjonkman, I agree. It looks like this was included in the TCF PR #537, and updated with your later PR #647. @HaymanConsulting, can you comment on this? |
andrew-platt
dismissed
their stale review
It appears these changes were already merged, and one bug introduced by them was fixed in #647.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request is NOT ready to be merged. Test results need to be verified with Nick Johnson and the OpenFAST team.
Development is complete, testing was performed (but not by the developer). No documentation changes needed other than perhaps to mention inclusion of the active aerodynamic control capability in the linearization scheme
Feature or improvement description
The active aerodynamic control capability (UserProp) is now included in the linearization scheme.
Impacted areas of the software
AeroDyn, FAST_Lin, FAST_Subs: Linearization of AeroDyn.