Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ElastoDyn: add YawBrTV[xyz]p output channels #653

Merged
merged 3 commits into from
Jan 30, 2021

Conversation

aitorplaza
Copy link
Contributor

This pull request is ready to be merged.

Feature or improvement description
This PR adds tower-top/ aw bearing translational absolute velocities directed along p reference.

  • YawBrTVxp: Tower-top / yaw bearing fore-aft (translational) velocity (absolute)
  • YawBrTVyp: Tower-top / yaw bearing side-to-side (translational) velocity (absolute)
  • YawBrTVzp: Tower-top / yaw bearing axial (translational) velocity (absolute)

Related issue, if one exists
None

Impacted areas of the software
ElastoDyn

Additional supporting information

Test results, if applicable

No test cases can be affected because this is output is new and not currently used by any of them.

Can you check it @andrew-platt ?

Copy link
Collaborator

@jjonkman jjonkman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me; thanks!

@andrew-platt
Copy link
Collaborator

@aitorplaza Thanks for contributing!

This PR will be merged after #537 (probably later this morning). One minor update will be required at that point for the OutlistParameters.xlsx file (that can't be merged automatically, and changes in #537). @aitorplaza, I will make that update and post a PR to your branch.

@aitorplaza
Copy link
Contributor Author

Thanks to you for your work. It's very useful to some of us.

@andrew-platt
Copy link
Collaborator

andrew-platt commented Jan 29, 2021

hi @aitorplaza , I created a PR to your branch at aitorplaza#2. This resolves the conflicts with docs/OtherSupporting/OutListParameters.xlsx. Once you accept that merge, we'll be able to merge this in.

Thanks again for your contribution!

andrew-platt and others added 2 commits January 29, 2021 14:33
This clears up the conflcit with docs/OtherSupporting/OutListParameters.xlsx
Merge of dev into YawBrTVxyzp
@aitorplaza
Copy link
Contributor Author

@andrew-platt PR accepted

@andrew-platt andrew-platt merged commit 4a32939 into OpenFAST:dev Jan 30, 2021
@aitorplaza aitorplaza deleted the YawBrTVxyzp branch February 18, 2021 08:55
@rafmudaf rafmudaf mentioned this pull request May 12, 2021
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants