Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] Stocks/Load - Cannot load monthly/weekly interval with Polygon as source. #2044

Closed
Tracked by #2051
deeleeramone opened this issue Jul 4, 2022 · 0 comments · Fixed by #2051
Closed
Tracked by #2051

[Bug] Stocks/Load - Cannot load monthly/weekly interval with Polygon as source. #2044

deeleeramone opened this issue Jul 4, 2022 · 0 comments · Fixed by #2051
Assignees
@hjoaquim

Comments

@deeleeramone
Copy link
Contributor

deeleeramone commented Jul 4, 2022 •
edited
Loading

The flags for Weekly and Monthly intervals is not working when Polygon is the source. Polygon allows any interval to be used, so this shouldn't be the result of the API limitations.

The sort fields for the --raw flag are not valid for Polygon as a source. There are different columns, and there is no column for LogRet and Returns.

Screen Shot 2022-07-04 at 10 24 50 AM

Screen Shot 2022-07-04 at 10 25 32 AM

Also, related to #2032 - sorting the raw data using candle --raw does not allow you to use the descending flag -d to show the tail of the data frame, i.e., the earliest date first.

Screen Shot 2022-07-04 at 10 30 42 AM
@hjoaquim hjoaquim mentioned this issue Jul 6, 2022
Merged
13 tasks
@hjoaquim hjoaquim linked a pull request Jul 6, 2022 that will close this issue
Fixes #2044 Stocks/Load - Cannot load monthly/weekly interval with Polygon as source. #2051
Merged
13 tasks
Chavithra added a commit that referenced this issue Jul 7, 2022
@hjoaquim @Chavithra
Fixes #2044 Stocks/Load - Cannot load monthly/weekly interval with Po…
e2eab7d 
…lygon as source. (#2051)

* fixed polygon timespan, it wasn't using the montly/weekly flags

* validate if the column exists before proceeding with the sort

* if the stock dataframe is empty we'll keep the previous behaviour. also, added quotes to keep the formatting the same as the original message.

Co-authored-by: Chavithra <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hjoaquim hjoaquim

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixes #2044 Stocks/Load - Cannot load monthly/weekly interval with Polygon as source.
2 participants
@hjoaquim @deeleeramone