Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #2044 Stocks/Load - Cannot load monthly/weekly interval with Polygon as source. #2051

Merged
merged 8 commits into from
Jul 7, 2022

Conversation

hjoaquim
Copy link
Contributor

@hjoaquim hjoaquim commented Jul 6, 2022

Description

Before
weeky_wrong

After
monthly
weekly

Sort arg verification:
not_found_col

  • Relevant motivation and context.
  • List any dependencies that are required for this change.

How has this been tested?

  • Please describe the tests that you ran to verify your changes.
  • Provide instructions so we can reproduce.
    Commands used:
  1. "load AMZN -s 1999-01-01 --source polygon --weekly"
  2. "load AMZN -s 1999-01-01 --source polygon --monthly"
  3. "load AMZN -s 1999-01-01 --source polygon --weekly" followed by "candle --raw --sort LogRet"
  • Please also list any relevant details for your test configuration.

Checklist:

Others

  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • My code passes all the checks pylint, flake8, black, ... To speed up development you should run pre-commit install.
  • New and existing unit tests pass locally with my changes. You can test this locally using pytest tests/....

@hjoaquim hjoaquim added the bug Fix bug label Jul 6, 2022
@DidierRLopes
Copy link
Collaborator

@hjoaquim if you use the wording "Fixes #ISSUENUMBER" then once this gets merged GitHub automatically closes that ticket, which is kinda neat.

And since you are here, can you have a look at #2050

@hjoaquim hjoaquim changed the title Fix Stocks/Load - Cannot load monthly/weekly interval with Polygon as source. #2044 Fixes #2044 Stocks/Load - Cannot load monthly/weekly interval with Polygon as source. Jul 6, 2022
@hjoaquim hjoaquim requested review from Chavithra and removed request for DidierRLopes July 6, 2022 08:54
Copy link
Contributor

@Chavithra Chavithra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Run it on my side.
Everything seems to work fine !

@Chavithra Chavithra merged commit e2eab7d into OpenBB-finance:main Jul 7, 2022
@hjoaquim hjoaquim deleted the bug-2044 branch July 7, 2022 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fix bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Stocks/Load - Cannot load monthly/weekly interval with Polygon as source.
3 participants