Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix sorting of candle data #2032

Merged
merged 6 commits into from
Jul 4, 2022
Merged

Fix sorting of candle data #2032

merged 6 commits into from
Jul 4, 2022

Conversation

DidierRLopes
Copy link
Collaborator

@DidierRLopes DidierRLopes added the bug Fix bug label Jul 3, 2022
@DidierRLopes DidierRLopes requested a review from jmaslek July 3, 2022 09:24
@deeleeramone
Copy link
Contributor

Still funky

Screen Shot 2022-07-03 at 11 18 51 PM
Screen Shot 2022-07-03 at 11 19 54 PM
Screen Shot 2022-07-03 at 11 22 05 PM

@DidierRLopes
Copy link
Collaborator Author

@deeleeramone the sorting doesn't work for the chart. Only for the raw data

@DidierRLopes DidierRLopes merged commit eba85a5 into main Jul 4, 2022
@deeleeramone
Copy link
Contributor

deeleeramone commented Jul 4, 2022 •
edited
Loading

@DidierRLopes I know this, I was simply showing that the raw data is not correct. Look at the adjusted close value. Where do the adjusted close numbers come from that are way off? There is no price history where it traded at those levels.

Screen Shot 2022-07-04 at 10 32 29 AM

Adjusted Close data from Polygon:
Screen Shot 2022-07-04 at 10 37 02 AM

Adjusted Close data from yFinance:
Screen Shot 2022-07-04 at 10 38 54 AM

@deeleeramone deeleeramone mentioned this pull request Jul 4, 2022
Closed
@DidierRLopes DidierRLopes deleted the 2031 branch July 4, 2022 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JerBouma JerBouma JerBouma approved these changes

@jmaslek jmaslek Awaiting requested review from jmaslek

Assignees
No one assigned
Labels
bug Fix bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug] Candle: Sorting by column does not change the date using --raw tables, which is the key value.
4 participants
@DidierRLopes @deeleeramone @JerBouma @minhhoang1023