FEAT/FIX: Picking the right PICK #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In Rebol2, picking value with index 0 was always returning null. In R3-alpha it was changed that zero index was working like index -1... more at this blog http://www.rebol.net/cgi-bin/r3blog.r?view=0173 I decided to revert this change and let it working as before (and so be compatible with Red too) So now it works for example like: >> pick tail "123" -1 == #"3" >> pick tail "123" 0 == none and it is also consistent with AT positioning: >> at tail "123" -1 == "3" Related issues: metaeducation/rebol-issues#608 metaeducation/rebol-issues#609 metaeducation/rebol-issues#748 metaeducation/rebol-issues#857 metaeducation/rebol-issues#2117 and also: metaeducation/rebol-issues#613
hostilefork
added a commit
to metaeducation/ren-c
that referenced
this pull request
Jun 14, 2018
Consensus in general was that the negative indexing behavior of R3-Alpha was not pleasing. This restores the historical behavior. Also makes it so that picking with DECIMAL! will round the decimal down and use the INTEGER! value, vs. SELECT-ing the DECIMAL. Commit initiated by Oldes in: Oldes#5 His comments there: "In Rebol2, picking value with index 0 was always returning null. In R3-Alpha it was changed that zero index was working like index -1... more at this blog http://www.rebol.net/cgi-bin/r3blog.r?view=0173" "I decided to revert this change and let it working as before (and so be compatible with Red too)" "So now it works for example like:" >> pick tail "123" -1 == #"3" >> pick tail "123" 0 == none "and it is also consistent with AT positioning:" >> at tail "123" -1 == "3" "Related issues:" metaeducation/rebol-issues#608 metaeducation/rebol-issues#609 metaeducation/rebol-issues#748 metaeducation/rebol-issues#857 metaeducation/rebol-issues#2117 "and also:" metaeducation/rebol-issues#613
This was referenced Feb 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Rebol2, picking value with index 0 was always returning null. In R3-alpha it was changed that zero index was working like index -1... more at this blog http://www.rebol.net/cgi-bin/r3blog.r?view=0173
I decided to revert this change and let it working as before (and so be compatible with Red too)
So now it works for example like:
and it is also consistent with AT positioning:
Related issues:
metaeducation/rebol-issues#608
metaeducation/rebol-issues#609
metaeducation/rebol-issues#748
metaeducation/rebol-issues#857
metaeducation/rebol-issues#2117
and also:
metaeducation/rebol-issues#613