PICK and POKE of strings have off-by-one error with indexes < 1.

[rebolbot]

Submitted by: BrianH

PICK and POKE of string types skip the 0 index, and negative indexes are shifted accordingly. PICK and POKE of block types work correctly.

; PICK of blocks

> > b: skip [a b c] 2
> > == [c]
> > pick b 2
> > == none
> > pick b 1
> > == c
> > pick b 0
> > == b
> > pick b -1
> > == a

; PICK of strings

> > b: skip "abc" 2
> > == "c"
> > pick b 2
> > == none
> > pick b 1
> > == #"c"
> > pick b 0
> > == none  ; should be #"b"
> > pick b -1
> > == #"b"  ; should be #"a"

^{CC – Data [ Version: alpha 33 Type: Bug Platform: All Category: n/a Reproduce: Always Fixed-in:alpha 55 ]}

[rebolbot]

Submitted by: BrianH

Note that this bug exists in R2, for blocks as well. This needs to be fixed – it’s like picking and poking in Roman numerals.

[rebolbot]

Submitted by: Carl

See also #857

[rebolbot]

Submitted by: BrianH

See also #609 - the same bug for AT.