Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AT has off-by-one error for indexes < 1. #609

Closed
Siskin-Bot opened this issue Feb 15, 2020 · 0 comments
Closed

AT has off-by-one error for indexes < 1. #609

Siskin-Bot opened this issue Feb 15, 2020 · 0 comments

Comments

@Siskin-Bot
Copy link
Collaborator

Submitted by: BrianH

AT series 0 is the same as AT series 1. For 1-based indexing, the 0 index should be one back from the current position, the -1 index two back, and so on.

This bug prevents calculation of the index argument, which is necessary for simulating 0-based indexing amongst other things. Both blocks and strings are affected.

Note: R2 also has this bug.


Imported from: CureCode [ Version: alpha 33 Type: Bug Platform: All Category: Unspecified Reproduce: Always Fixed-in:none ]
Imported from: metaeducation#609

Comments:

Rebolbot commented on Mar 5, 2014:

Submitted by: BrianH

According to the index compromise in #2117 this is not a bug.


Rebolbot commented on Mar 6, 2014:

Submitted by: abolka

According to #2117 a part of this ticket is still important: AT series 0 should cause an error. But it's best to track that in a separate ticket.


Rebolbot mentioned this issue on Jan 12, 2016:
Make VECTOR! of same index-base as other series


Rebolbot added on Jan 12, 2016


Oldes added a commit to Oldes/Rebol3 that referenced this issue on Jun 13, 2018:
FEAT/FIX: Picking the right PICK


Oldes mentioned this pullrequest on Jun 13, 2018:
FEAT/FIX: Picking the right PICK


Hostilefork added a commit to metaeducation/ren-c that referenced this issue on Jun 14, 2018:
Restore Rebol2-era PICKing/PATHing of negative/zero indices


Hostilefork mentioned this pullrequest on Jun 14, 2018:
Restore Rebol2-era PICKing/PATHing of negative/zero indices


Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant