-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create release v6 #283
Create release v6 #283
Conversation
c0984fc
to
109fe3d
Compare
"label": "Packages", | ||
"defaultValue": "", | ||
"required": false, | ||
"helpMarkDown": "A multi-line list of version numbers to use for a package in the release. Format: StepName:Version or PackageID:Version or StepName:PackageName:Version. StepName, PackageID, and PackageName can be replaced with an asterisk ('*'). An asterisk will be assumed for StepName, PackageID, or PackageName if they are omitted." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a difference between PackageId
and PackageName
here? It feels confusing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is, and yes it is. PackageID is what it sounds like, PackageName is the package reference name on the step, which is a far more confusing thing. For default packages (Deploy a Package step) it will be null/empty, for "additional packages" it will default to the PackageID when the reference is being added but the user can override it to whatever they want. It's there for some edge case where you can have the same PackageID referenced more than once on a step (to allow setting different versions for them during release creation. My understanding it's a use case where customer want V and V-1 to they can do some delta work on the packages)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
One comment regarding wording in Packages
field help text
source/tasks/CreateOctopusRelease/CreateOctopusReleaseV6/input-parameters.test.ts
Outdated
Show resolved
Hide resolved
…ame consistent with the other steps
a22c771
to
e7a8f4c
Compare
feat: New steps for Zip/NuGet pack (#276) feat:push step v6 (#277) feat: deploy release v6 (#278) feat: deploy tenant release v6 (#281) feat: await task (#282) feat: Run runbook step (#285) feat: Create release v6 (#283) chore: updated the way user agent strings are built for the v6 steps (#287) feat: push build information v6 (#284) chore: Added output variable definitions for the Pack steps feat: CLI installer step - v6 (#279) chore: added warning logs for use of additional arguments fields (#286) chore: fixed some pluralisation inconsistencies Co-authored-by: Ben Pearce <[email protected]>
Create Release step v6, using the executions API.