feat: deploy tenant release v6 #281
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Shannon Lewis <[email protected]>
Co-authored-by: Shannon Lewis <[email protected]>
benPearce1
changed the title
slewis74
approved these changes
Jan 16, 2023
| "defaultValue": "", | ||
| "required": true, | ||
| "properties": { | ||
| "EditableOptions": "True" |
There was a problem hiding this comment.
this isn't needed now we aren't using the selectors
| if (parameters.space === "") { | ||
| errors.push("The Octopus space name is required."); | ||
| } | ||
|
|
There was a problem hiding this comment.
we could add some validation here for tenants/tags to help the users. There should be at least 1 tenant or 1 tag.
| "minimumAgentVersion": "2.144.0", | ||
| "groups": [ | ||
| { | ||
| "name": "tenant", |
There was a problem hiding this comment.
feels like this probably isn't needed for this step. The groups are good for collapsing optional/advanced things out of the way, but Tenants are required for this step so should always be visible.
There was a problem hiding this comment.
group removed, ui screenshot updated
benPearce1
added a commit
that referenced
this pull request
Feb 8, 2023
feat: New steps for Zip/NuGet pack (#276) feat:push step v6 (#277) feat: deploy release v6 (#278) feat: deploy tenant release v6 (#281) feat: await task (#282) feat: Run runbook step (#285) feat: Create release v6 (#283) chore: updated the way user agent strings are built for the v6 steps (#287) feat: push build information v6 (#284) chore: Added output variable definitions for the Pack steps feat: CLI installer step - v6 (#279) chore: added warning logs for use of additional arguments fields (#286) chore: fixed some pluralisation inconsistencies Co-authored-by: Ben Pearce <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deploy for specific tenants
Deploy for tenant tags: