Enh deploy release v6 #278
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benPearce1
commented
Jan 12, 2023
| @@ -127,11 +126,12 @@ function Pack($envName, $environment, $workingDirectory) { | |||
|
|
|||
| & ./node_modules/.bin/tfx extension create --root $workingDirectory --manifest-globs extension-manifest.json --overridesFile $overridesFile --outputPath "$buildArtifactsPath/$environment" --no-prompt | |||
|
|
|||
| if (-not $?) {throw "Failed to create extension. Exit Code $LASTEXITCODE"} | |||
| & npm uninstall tfx-cli | |||
There was a problem hiding this comment.
This is the only change to this line, the rest was auto-formatting kicking in
benPearce1
commented
Jan 13, 2023
| import { getInputParameters } from "./input-parameters"; | ||
| import * as tasks from "azure-pipelines-task-lib/task"; | ||
|
|
||
| export class MockTaskWrapper implements TaskWrapper { |
There was a problem hiding this comment.
This needs to move to a common location, but I initially had a reference issue so I put it here for now
benPearce1
commented
Jan 13, 2023
| "label": "Additional Arguments (deprecated)", | ||
| "defaultValue": "", | ||
| "required": false, | ||
| "helpMarkDown": "Additional arguments are no longer supported, move these values to the appropriate fields", |
benPearce1
commented
Jan 13, 2023
| ], | ||
| "instanceNameFormat": "Deploy Octopus Release", | ||
| "execution": { | ||
| "Node16": { |
benPearce1
commented
Jan 13, 2023
| import commandLineArgs from "command-line-args"; | ||
| import shlex from "shlex"; | ||
|
|
||
| describe("cli args", () => { |
There was a problem hiding this comment.
These tests were me working out how to parse the arguments from the AdditionalArguments field, thought I would leave them here for future reference
slewis74
suggested changes
Jan 13, 2023
Co-authored-by: Shannon Lewis <[email protected]>
Co-authored-by: Shannon Lewis <[email protected]>
slewis74
approved these changes
Jan 16, 2023
benPearce1
added a commit
that referenced
this pull request
Feb 8, 2023
feat: New steps for Zip/NuGet pack (#276) feat:push step v6 (#277) feat: deploy release v6 (#278) feat: deploy tenant release v6 (#281) feat: await task (#282) feat: Run runbook step (#285) feat: Create release v6 (#283) chore: updated the way user agent strings are built for the v6 steps (#287) feat: push build information v6 (#284) chore: Added output variable definitions for the Pack steps feat: CLI installer step - v6 (#279) chore: added warning logs for use of additional arguments fields (#286) chore: fixed some pluralisation inconsistencies Co-authored-by: Ben Pearce <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supports variables coming from either additional arguments or the variable field
In ui mode
