Apply Doctrine Coding Standard

[VolCh]

Renamed in /src:

\GeneratedHydratorBenchmark\{HydrationBenchInterface -> HydrationBench}
\GeneratedHydrator\ClassGenerator\{HydratorGeneratorInterface -> HydratorGenerator}
\GeneratedHydrator\ClassGenerator\{HydratorGenerator -> DefaultHydratorGenerator}
\GeneratedHydrator\Exception\{ExceptionInterface -> Exception}
\GeneratedHydrator\Exception\{DisabledMethodException::desabledMethod ->DisabledMethod::create}

[Ocramius]

@VolCh please also add the phpcs checks to .travis.yml 👍

[VolCh]

@Ocramius should we maintain PHP 7.0 compatible or I shall take in mind #74 with PHP 7.1 at least?

[Ocramius]

You can gladly bump to 7.2 FWIW

…

On Sat, 12 May 2018, 12:13 Vladimir Chernyshev, ***@***.***> wrote: @Ocramius <https://github.com/Ocramius> should we maintain PHP 7.0 compatible or I shall take in mind #74 <#74> with PHP 7.1 at least? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#77 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAJakO2rd4jRkNNKTSmFE9TBEOOkJlhXks5txrXhgaJpZM4T6a1C> .

[VolCh]

@Ocramius I renamed classes

\GeneratedHydrator\ClassGenerator\\{
HydratorGeneratorInterface -> HydratorGenerator,
HydratorGenerator -> DefaultHydratorGenerator
}
\GeneratedHydrator\Exception\{
ExceptionInterface -> Exception,
DisabledMethodException::disabledMethod ->DisabledMethod::create
}

Also i'm not sure that \GeneratedHydrator\Configuration::DEFAULT_GENERATED_CLASS_NAMESPACE should be public

[VolCh]

@Ocramius is this PR acceptable now?

[Ocramius]

Hmm, this is a major BC break: would have preferred an exclusion rule, but let's roll with it

[Ocramius]

Requires a rebase, but otherwise good to go by me 👍

[VolCh]

Done. Also fixed few @var phpdocs

[Ocramius]

👍 thanks!

[redthor]

I don't suppose we could keep the library to php 7.1 for release 3.0.0?

When I trialled #79 I had to go to the 2.2.0 tag to be able to composer update (I could --ignore-platfrom-requirements but I was just thinking if there isn't something specifically in php7.2 we could keep it at php7.1...)

[Ocramius]

@redthor I bump my dependency versions regularly anyway: using an older stable version of the library is perfectly OK.

[Majkl578]

I'd say it's preferable to do file-level excludes in phpcs.xml.dist rather than using inline comments.