Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade nikic/php-parser and code-generator-utils to their latest versions #81

Merged
merged 1 commit into from
Mar 2, 2019
Merged

Upgrade nikic/php-parser and code-generator-utils to their latest versions #81

merged 1 commit into from
Mar 2, 2019

Conversation

WyriHaximus
Copy link
Contributor

@WyriHaximus WyriHaximus commented Mar 2, 2019 •
edited by Ocramius
Loading

Fixes #79

@WyriHaximus WyriHaximus mentioned this pull request Mar 2, 2019
Closed
@Ocramius Ocramius self-assigned this Mar 2, 2019
@Ocramius Ocramius added this to the 2.3.0 milestone Mar 2, 2019
Ocramius
Ocramius approved these changes Mar 2, 2019
View reviewed changes
Copy link
Owner

@Ocramius Ocramius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@Ocramius Ocramius merged commit 1251d31 into Ocramius:master Mar 2, 2019
@WyriHaximus
Copy link
Contributor Author

🎉

@WyriHaximus
Copy link
Contributor Author

While I love to see this tagged sooner rather then later are you sure 2.3.0 is the best version since this does a major update for both dependencies?

@Ocramius
Copy link
Owner

Ocramius commented Mar 4, 2019

are you sure 2.3.0 is the best version since this does a major update for both dependencies?

Yes: none of the public API of this project changes, so a minor version bump is fine.

@WyriHaximus
Copy link
Contributor Author

Ok great 👍 !

@Ocramius
Copy link
Owner

Ocramius commented Mar 4, 2019

Ah, no, further (breaking) changes already made it into master via #77, so I have to tag a new major anyway

@Ocramius Ocramius modified the milestones: 2.3.0, 3.0.0 Mar 4, 2019
@WyriHaximus
Copy link
Contributor Author

Haha ok, anyway I can help speed that up?

@Ocramius
Copy link
Owner

Ocramius commented Mar 4, 2019

Currently doing that :-)

@WyriHaximus
Copy link
Contributor Author

party-hard

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ocramius Ocramius Ocramius approved these changes

Assignees

@Ocramius Ocramius

Labels
enhancement
Projects
None yet
Milestone
3.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@WyriHaximus @Ocramius