Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PHP 7.1+, Use PHPUnit 7 #74

Merged
merged 2 commits into from
May 23, 2018
Merged

PHP 7.1+, Use PHPUnit 7 #74

merged 2 commits into from
May 23, 2018

Conversation

Majkl578
Copy link
Contributor

@Majkl578 Majkl578 commented May 1, 2018

No description provided.

@Ocramius
Copy link
Owner

Ocramius commented May 8, 2018

This patch also needs to bump the minimum PHP version

@Majkl578
Copy link
Contributor Author

Majkl578 commented May 8, 2018

Yeah, my assertion that your libs are 7.1+/7.2+ only failed. 😝

@Majkl578 Majkl578 changed the title Use PHPUnit 7 PHP 7.1+, Use PHPUnit 7 May 8, 2018
@Ocramius Ocramius self-assigned this May 8, 2018
@Ocramius Ocramius added this to the 2.2.0 milestone May 8, 2018
@Ocramius
Copy link
Owner

Ocramius commented May 8, 2018

A .travis.yml update is also needed, sorry :S

@Ocramius Ocramius assigned Majkl578 and unassigned Ocramius May 8, 2018
@Ocramius Ocramius removed this from the 2.2.0 milestone May 8, 2018
@VolCh VolCh mentioned this pull request May 12, 2018
Merged
@Ocramius Ocramius added this to the 2.2.0 milestone May 23, 2018
Ocramius
Ocramius approved these changes May 23, 2018
View reviewed changes
Copy link
Owner

@Ocramius Ocramius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@Ocramius Ocramius merged commit aed0e44 into Ocramius:master May 23, 2018
@Ocramius
Copy link
Owner

Thanks @Majkl578!

@Majkl578 Majkl578 deleted the phpunit7 branch May 23, 2018 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@malukenho malukenho malukenho approved these changes

@Ocramius Ocramius Ocramius approved these changes

Assignees

@Majkl578 Majkl578

Labels
enhancement
Projects
None yet
Milestone
2.2.0
Development

Successfully merging this pull request may close these issues.
3 participants
@Majkl578 @Ocramius @malukenho