Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

*: cherry pick 2685 and 2673 #2689

Merged
merged 2 commits into from
Nov 8, 2023
Merged

*: cherry pick 2685 and 2673 #2689

merged 2 commits into from
Nov 8, 2023

Conversation

dB2510
Copy link
Contributor

@dB2510 dB2510 commented Nov 8, 2023

xenowits and others added 2 commits November 8, 2023 19:43
@xenowits @dB2510
obolapi: update publish lock timeout to 30s (#2685)
5917f73 
Update timeout to 30s for publishing lock to obol-api. This ensures that DKG doesn't error if lock files are large enough (>200kb) whose publishing takes more than 5s. 

30s is an empirical timeout value which is safe for publishing large lock files (1.5MB)  to obol-api.

category: refactor 
ticket: none
@dB2510
cmd/createcluster: fix pre-gen builder registrations (#2673)
4cbb6c6 
This PR fixes a bug in the `create cluster` command that was generating incorrect builder registrations in cluster-lock.json. The issue stemmed from the usage of withdrawal addresses instead of fee recipient addresses, which resulted in signature verification failures when the command was used for the 'charon run' operation.

Here's the error log caused by this bug:
![image](https://github.com/ObolNetwork/charon/assets/37813203/42f3fa00-cff8-4107-b8c1-55d91f485a42)


category: bug
ticket: #2674
@dB2510 dB2510 requested review from gsora and xenowits November 8, 2023 14:17
@github-actions github-actions bot added the branch-release PR or Issue linked to a release branch (not main) label Nov 8, 2023
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 8, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@dB2510 dB2510 added the merge when ready Indicates bulldozer bot may merge when all checks pass label Nov 8, 2023
@dB2510 dB2510 self-assigned this Nov 8, 2023
@obol-bulldozer obol-bulldozer bot merged commit eb8870d into main-v0.17 Nov 8, 2023
13 checks passed
@obol-bulldozer obol-bulldozer bot deleted the dhruv/cherryv0.17.2 branch November 8, 2023 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xenowits xenowits xenowits approved these changes

@gsora gsora gsora approved these changes

Assignees

@dB2510 dB2510

Labels
branch-release PR or Issue linked to a release branch (not main) merge when ready Indicates bulldozer bot may merge when all checks pass
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dB2510 @gsora @xenowits