-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cmd/createcluster: fix pre-gen builder registrations #2673
Conversation
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2673 +/- ##
==========================================
+ Coverage 53.00% 53.03% +0.03%
==========================================
Files 202 202
Lines 28006 28006
==========================================
+ Hits 14844 14853 +9
+ Misses 11301 11292 -9
Partials 1861 1861
☔ View full report in Codecov by Sentry. |
Small feedback @dB2510
I think we should develop a shared framework for how we name bug severities. This would have made mev registrations fail for a specific subset of scenarios, and local block production may have worked. Either way, I would not put 'could miss block' in the critical category here, and would save that for loss of funds not missed opportunities. |
Hey @OisinKyne |
This PR fixes a bug in the `create cluster` command that was generating incorrect builder registrations in cluster-lock.json. The issue stemmed from the usage of withdrawal addresses instead of fee recipient addresses, which resulted in signature verification failures when the command was used for the 'charon run' operation. Here's the error log caused by this bug: ![image](https://github.com/ObolNetwork/charon/assets/37813203/42f3fa00-cff8-4107-b8c1-55d91f485a42) category: bug ticket: #2674
This PR fixes a bug in the
create cluster
command that was generating incorrect builder registrations in cluster-lock.json. The issue stemmed from the usage of withdrawal addresses instead of fee recipient addresses, which resulted in signature verification failures when the command was used for the 'charon run' operation.Here's the error log caused by this bug:
category: bug
ticket: #2674