Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect pre-gen builder registrations in create cluster ouput #2674

Closed
dB2510 opened this issue Nov 6, 2023 · 0 comments · Fixed by #2673
Closed

Incorrect pre-gen builder registrations in create cluster ouput #2674

dB2510 opened this issue Nov 6, 2023 · 0 comments · Fixed by #2673
Assignees
@dB2510
Labels
protocol Protocol Team tickets v0.17.2

Comments

@dB2510
Copy link
Contributor

dB2510 commented Nov 6, 2023 •
edited
Loading

🐞 Bug Report

Description

charon create cluster command generates a cluster-lock.json file which has incorrect builder registrations. It consists of withdrawal addresses instead of fee-recipient addresses which causes lock verification to fail.

Has this worked before in a previous version?

No

🔬 Minimal Reproduction

Run create cluster command with different fee-recipient and withdrawal address and check fee_recipient field in builder_registration data for the given withdrawal address.

🔥 Error

image

🌍 Your Environment

What version of Charon are you running? (Which release)

  
v0.17.1
@github-actions github-actions bot added the protocol Protocol Team tickets label Nov 6, 2023
@dB2510 dB2510 self-assigned this Nov 6, 2023
@dB2510 dB2510 added the v0.17.2 label Nov 6, 2023
@dB2510 dB2510 mentioned this issue Nov 6, 2023
Merged
@dB2510 dB2510 linked a pull request Nov 6, 2023 that will close this issue
cmd/createcluster: fix pre-gen builder registrations #2673
Merged
obol-bulldozer bot pushed a commit that referenced this issue Nov 6, 2023
@dB2510
cmd/createcluster: fix pre-gen builder registrations (#2673)
be36a73 
This PR fixes a bug in the `create cluster` command that was generating incorrect builder registrations in cluster-lock.json. The issue stemmed from the usage of withdrawal addresses instead of fee recipient addresses, which resulted in signature verification failures when the command was used for the 'charon run' operation.

Here's the error log caused by this bug:
![image](https://github.com/ObolNetwork/charon/assets/37813203/42f3fa00-cff8-4107-b8c1-55d91f485a42)


category: bug
ticket: #2674
dB2510 added a commit that referenced this issue Nov 8, 2023
@dB2510
cmd/createcluster: fix pre-gen builder registrations (#2673)
4cbb6c6 
This PR fixes a bug in the `create cluster` command that was generating incorrect builder registrations in cluster-lock.json. The issue stemmed from the usage of withdrawal addresses instead of fee recipient addresses, which resulted in signature verification failures when the command was used for the 'charon run' operation.

Here's the error log caused by this bug:
![image](https://github.com/ObolNetwork/charon/assets/37813203/42f3fa00-cff8-4107-b8c1-55d91f485a42)


category: bug
ticket: #2674
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dB2510 dB2510

Labels
protocol Protocol Team tickets v0.17.2
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

cmd/createcluster: fix pre-gen builder registrations ObolNetwork/charon
1 participant
@dB2510