[16.0][ADD] stock_storage_category_usage_report #352
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rousseldenis
force-pushed
the
16.0-add-stock-storage-category-report-dro
branch
from
400afc6 to
e05d1f3
Compare
rousseldenis
force-pushed
the
16.0-add-stock-storage-category-report-dro
branch
from
e05d1f3 to
dd30f32
Compare
jbaudoux
requested changes
Nov 13, 2024
stock_storage_category_usage_report/models/stock_storage_category.py
Outdated
Show resolved
Hide resolved
rousseldenis
force-pushed
the
16.0-add-stock-storage-category-report-dro
branch
2 times, most recently
from
33dd8cb to
243db31
Compare
rousseldenis
force-pushed
the
16.0-add-stock-storage-category-report-dro
branch
4 times, most recently
from
b68aaa0 to
6f6733f
Compare
…_location_fill_rate
rousseldenis
force-pushed
the
16.0-add-stock-storage-category-report-dro
branch
from
6f6733f to
d454ebc
Compare
jbaudoux
reviewed
Nov 20, 2024
| # (move qty is done but not yet validated). | ||
| # We don't take into account filled and being filled moves. | ||
| empty_locations = all_locations.filtered( | ||
| lambda location: location.fill_state == "empty" |
There was a problem hiding this comment.
Suggested change
| lambda location: location.fill_state == "empty" | |
| lambda location: location.fill_state in ("empty", "being_emptied") |
Comment on lines
+5
to
+8
| "name": "Stock Storage Category Usage Report", | ||
| "summary": """ | ||
| This module allows to get reporting on stock storage categories | ||
| about their locations usage""", |
There was a problem hiding this comment.
What about renaming to use fill instead of usage as this relates to that field?
Suggested change
| "name": "Stock Storage Category Usage Report", | |
| "summary": """ | |
| This module allows to get reporting on stock storage categories | |
| about their locations usage""", | |
| "name": "Stock Storage Category Fill Report", | |
| "summary": """ | |
| This module allows to get reporting on stock storage categories | |
| about their locations fill rate""", |
jbaudoux
reviewed
Nov 20, 2024
| @@ -0,0 +1,2 @@ | |||
| When users want to manage their stock locations in a better way, | |||
| they need those locations' usage (empty/filled in). | |||
There was a problem hiding this comment.
Maybe DESCRIPTION is enough. It's kind of repeating
Suggested change
| they need those locations' usage (empty/filled in). | |
| they need those location storage categories' fill rate (amount of empty/filled location). |
jbaudoux
reviewed
Nov 20, 2024
| #: model:ir.ui.menu,name:stock_storage_category_usage_report.report_storage_category_root_menu | ||
| #: model:ir.ui.menu,name:stock_storage_category_usage_report.report_storage_category_view_menu | ||
| msgid "Stock Storage Category Usage Report" | ||
| msgstr "Rapport d'utilisation des catégories d'empalcement" |
There was a problem hiding this comment.
:) ou Rapport de taux de remplissage
Suggested change
| msgstr "Rapport d'utilisation des catégories d'empalcement" | |
| msgstr "Rapport d'utilisation des catégories d'emplacements" |
jbaudoux
reviewed
Nov 20, 2024
| #. module: stock_storage_category_usage_report | ||
| #: model:ir.model,name:stock_storage_category_usage_report.model_stock_storage_category | ||
| msgid "Storage Category" | ||
| msgstr "Catégories d'emplacement" |
There was a problem hiding this comment.
Suggested change
| msgstr "Catégories d'emplacement" | |
| msgstr "Catégorie d'emplacement" |
jbaudoux
reviewed
Nov 20, 2024
| @@ -0,0 +1,73 @@ | |||
| # Translation of Odoo Server. | |||
jbaudoux
reviewed
Nov 20, 2024
| </record> | ||
|
|
||
| <record model="ir.actions.act_window" id="report_storage_category_usage_act_window"> | ||
| <field name="name">Stock Storage Category Usage Report</field> |
There was a problem hiding this comment.
Suggested change
| <field name="name">Stock Storage Category Usage Report</field> | |
| <field name="name">Storage Categories Fill Rate Report</field> |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on:
Example: