[16.0][MIG] stock_location_children #2190
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Any child_ids changed on a children_ids should recompute locations: otherwise only 2 levels are updated. * Flush any change in the hierarchy before executing the SQL
When other modules add locations in "stock.stock_location_stock", the assertions miss them. Create a new tree of locations to run the tests.
Currently translated at 100.0% (6 of 6 strings) Translation: stock-logistics-warehouse-14.0/stock-logistics-warehouse-14.0-stock_location_children Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-warehouse-14-0/stock-logistics-warehouse-14-0-stock_location_children/it/
Currently translated at 100.0% (6 of 6 strings) Translation: stock-logistics-warehouse-14.0/stock-logistics-warehouse-14.0-stock_location_children Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-warehouse-14-0/stock-logistics-warehouse-14-0-stock_location_children/it/
Currently translated at 100.0% (6 of 6 strings) Translation: stock-logistics-warehouse-14.0/stock-logistics-warehouse-14.0-stock_location_children Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-warehouse-14-0/stock-logistics-warehouse-14-0-stock_location_children/it/
Improve readability of code without impacting performances
|
/ocabot migration stock_location_children |
rousseldenis
force-pushed
the
2.16-mig-stock-location-children-dro
branch
from
fb036da to
8eea61b
Compare
rousseldenis
force-pushed
the
2.16-mig-stock-location-children-dro
branch
from
8eea61b to
1f54573
Compare
lmignon
approved these changes
Nov 13, 2024
|
This PR has the |
jbaudoux
reviewed
Nov 13, 2024
Comment on lines
+27
to
+37
| query = """SELECT sub.id, ARRAY_AGG(sl2.id) AS children | ||
| FROM stock_location sl2, | ||
| ( | ||
| SELECT id, parent_path | ||
| FROM stock_location sl | ||
| ) sub | ||
| WHERE sl2.parent_path LIKE sub.parent_path || '%%' | ||
| AND sl2.id != sub.id | ||
| AND sub.id IN %s | ||
| GROUP BY sub.id; | ||
| """ |
There was a problem hiding this comment.
Maybe more readable than sub and sl2:
Suggested change
| query = """SELECT sub.id, ARRAY_AGG(sl2.id) AS children | |
| FROM stock_location sl2, | |
| ( | |
| SELECT id, parent_path | |
| FROM stock_location sl | |
| ) sub | |
| WHERE sl2.parent_path LIKE sub.parent_path || '%%' | |
| AND sl2.id != sub.id | |
| AND sub.id IN %s | |
| GROUP BY sub.id; | |
| """ | |
| query = """ | |
| SELECT sl.id, ARRAY_AGG(child.id) AS children | |
| FROM stock_location sl | |
| JOIN stock_location child | |
| ON child.parent_path LIKE sl.parent_path || '_%%' | |
| AND sl.id IN %s | |
| GROUP BY sl.id | |
| """ |
There was a problem hiding this comment.
Yes, I didn't want to modify things that worked before.
jbaudoux
approved these changes
Nov 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
supersedes #1802
Added some improvements