[16.0][ADD] stock_location_fill_state

[rousseldenis]

This is different from https://github.com/OCA/stock-logistics-warehouse/tree/14.0/stock_location_empty

As we don't compute stock amount.

Depends on:

• [16.0][ADD] stock_location_pending_move #2200

[jbaudoux]

According to me, the right implementation is here
https://github.com/OCA/wms/blob/16.0/stock_storage_type/models/stock_location.py#L319

I would have migrated the stock_location_empty and extracted the computation from the above code to compute stock_amount and location_is_empty. It's not the exact same computation as in 14.0 but it's the most correct one in my opinion and improving previous implementation. Then we don't end-up with 3 modules computing the same concept in 3 different ways.

I prefer empty than void. And occupied state is like there is an hostile army ;)

Occupancy is also misleading as I thought initially it was about volume...

[jbaudoux]

You can still have quants with 0 quantity. So that's not inline with the help no product quantity

[jbaudoux]

cc @p-tombez @TDu @sebalix

[rousseldenis]

According to me, the right implementation is here
https://github.com/OCA/wms/blob/16.0/stock_storage_type/models/stock_location.py#L319

Yes, in fact, I had this in mind but wanted simpler implementation.

I would say, we should maybe transform the boolean state to a Selection one, with an 'Operation in Progress' (yellow color) there:

[jbaudoux]

I would say, we should maybe transform the boolean state to a Selection one, with an 'Operation in Progress' (yellow color)

• empty = green
• being filled = yellow
• filled = red
• being emptied = orange

[rousseldenis]

I would say, we should maybe transform the boolean state to a Selection one, with an 'Operation in Progress' (yellow color)

• empty = green
• being filled = yellow
• filled = red
• being emptied = orange

@jbaudoux

being emptied and being filled : which one has priority on the other ?

That's why I proposed operation in progress as we can have both at the same time.

[jbaudoux]

being emptied and being filled : which one has priority on the other ?

Being emptied is when there is stock but entirely reserved for move lines with qty done. Equals to current implementation of is empty in storage type module.

Being filled is when it is empty but there are move line with location as destination.

As one is when there is stock and the other when there is no stock, you cannot have both, it is exclusive