Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ADD] purchase_exception to 11.0 #467

Closed
wants to merge 2 commits into from
Closed

[ADD] purchase_exception to 11.0 #467

wants to merge 2 commits into from

Conversation

mourad-ehm
Copy link
Contributor

@mourad-ehm mourad-ehm commented Oct 13, 2017 •
edited by lasley
Loading

This module add exception management to purchase (based on base_exception).
A user can add new exceptions to block purchase if qty is < 0 for example.
Depends on:

@mourad-ehm mourad-ehm mentioned this pull request Oct 13, 2017
Closed
@mourad-ehm mourad-ehm force-pushed the 11.0-add-purchase_exception branch 2 times, most recently from 2ba313d to 595465f Compare October 17, 2017 07:08
rousseldenis
rousseldenis reviewed Oct 18, 2017
View reviewed changes
Copy link
Contributor

@rousseldenis rousseldenis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Typo

purchase_exception/data/purchase_exception_data.xml Outdated

<record id ="po_excep_no_email" model="exception.rule">
<field name="name">No email on vendor</field>
<field name="description">No Email for Vondor</field>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Vendor

lasley
lasley reviewed Nov 14, 2017
View reviewed changes
oca_dependencies.txt Outdated
@@ -0,0 +1 @@
server-tools https://github.com/akretion/server-tools 11.0-mig-base_exception
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What pull request does this depend on?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OCA/server-tools#1025

@JordiBForgeFlow JordiBForgeFlow changed the title [ADD] purchade_exception to 11.0 [ADD] purchase_exception to 11.0 Nov 22, 2017
@bealdav
Copy link
Member

bealdav commented Nov 23, 2017

result log in runbot is

2017-11-23 09:14:27,108 159 INFO openerp_test odoo.modules.loading: Modules loaded.
2017-11-23 09:14:27,111 159 INFO openerp_test odoo.models: Computing parent left and right for table ir_ui_menu...
2017-11-23 09:14:27,155 159 INFO openerp_test odoo.service.server: Initiating shutdown
2017-11-23 09:14:27,155 159 INFO openerp_test odoo.service.server: Hit CTRL-C again or send a second signal to force the shutdown.

Module test summary
�[1;32mSuccess�[0;m purchase_exception

+=======================================

Tests summary:
test_server.py �[1;32mSuccess�[0;m
+=======================================

Then I think it's a false fail.

What do you think @jbeficent ?

@JordiBForgeFlow
Copy link
Member

@bealdav @mourad-ehm See akretion#5

@JordiBForgeFlow JordiBForgeFlow mentioned this pull request Nov 23, 2017
Merged
2 tasks
@mourad-ehm mourad-ehm closed this Nov 27, 2017
@mourad-ehm mourad-ehm reopened this Nov 27, 2017
@bealdav
Copy link
Member

bealdav commented Nov 27, 2017

Yet runbot false negative

2017-11-23 15:14:49,124 159 INFO openerp_test odoo.modules.loading: 35 modules loaded in 1.31s, 9 queries
2017-11-23 15:14:49,659 159 INFO openerp_test odoo.modules.loading: Modules loaded.
2017-11-23 15:14:49,663 159 INFO openerp_test odoo.models: Computing parent left and right for table ir_ui_menu...
2017-11-23 15:14:49,706 159 INFO openerp_test odoo.service.server: Initiating shutdown
2017-11-23 15:14:49,706 159 INFO openerp_test odoo.service.server: Hit CTRL-C again or send a second signal to force the shutdown.

Module test summary
�[1;32mSuccess�[0;m purchase_exception

+=======================================

Tests summary:
test_server.py �[1;32mSuccess�[0;m
+=======================================

@rousseldenis
Copy link
Contributor

@bealdav Due to base_exception module (not merged yet)

@mourad-ehm mourad-ehm force-pushed the 11.0-add-purchase_exception branch from d1f8c5e to 0164fa8 Compare December 6, 2017 11:02
@mourad-ehm mourad-ehm mentioned this pull request Dec 6, 2017
Merged
@lasley lasley added this to the 11.0 milestone Dec 19, 2017
@lasley
Copy link

lasley commented Dec 19, 2017

@mourad-ehm - base_exception has been merged. Please rebase 🚀

@JordiBForgeFlow
Copy link
Member

@mourad-ehm - can you rebase? I'm depending on this PR to merge other modules.

This was referenced Dec 27, 2017
Closed
Closed
@JordiBForgeFlow
Copy link
Member

@mourad-ehm PR OCA/server-tools#1111 fixes the problem in base_exception

@JordiBForgeFlow
Copy link
Member

You can see how the test is green in PR #487

@mourad-ehm
Copy link
Contributor Author

Thanks @jbeficent for the correction. Sorry for my late response. I'm on vacation.

@JordiBForgeFlow
Copy link
Member

merged in #487

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rousseldenis rousseldenis rousseldenis left review comments

@JordiBForgeFlow JordiBForgeFlow JordiBForgeFlow left review comments

@lasley lasley lasley left review comments

@bealdav bealdav bealdav approved these changes

Assignees
No one assigned
Labels
needs review
Projects
None yet
Milestone
11.0
Development

Successfully merging this pull request may close these issues.
5 participants
@mourad-ehm @bealdav @JordiBForgeFlow @rousseldenis @lasley