[11.0][MIG] sale_exception #576

simahawk · 2017-11-28T16:01:51Z

No description provided.

simahawk · 2017-11-28T16:03:49Z

missing dependency on OCA/server-tools#1025.

@pedrobaeza I lost some OCA Transbot commits because of some bad conflicts on rebase cleanup. Can we rely on transbot to update them again when merged or should I try to recover all of them?

pedrobaeza · 2017-11-28T16:05:45Z

As this is a new branch, it will be a new project, so you have to put the correct translations. The best option is: copy translation files from 10.0, make a commit, and squash it with latest "OCA Transbot commit".

As a side note, these conflicts happened when dirty merge/pull operations have been done in the branch in the past. Fortunately, we can fix them here for the future.

simahawk · 2017-11-28T16:06:47Z

ok then, I'll drop all of them and get back from v10. Thanks

simahawk · 2017-11-29T10:05:11Z

@pedrobaeza translations recovered (no transbot commit to squash with tho).
About build: it complains about base_exception not found but I added this https://github.com/simahawk/sale-workflow/blob/a5cec451f89af26433a650d7a8bd5cd83c913856/oca_dependencies.txt
Is that correct?

pedrobaeza · 2017-11-29T11:16:59Z

The problem is not about base_exception, but another. Please check Travis logs.

simahawk · 2017-11-29T11:19:55Z

@pedrobaeza ah sorry, I looked at an old build that was still failing for dependency issue :(

StefanRijnhart

Tests are green, translations are salvaged! Perhaps squash your own commits @simahawk?

LoisRForgeFlow · 2017-12-05T15:57:28Z

oca_dependencies.txt

@@ -0,0 +1,2 @@
+# base_exception v11 https://github.com/OCA/server-tools/pull/1025
+server-tools https://github.com/akretion/server-tools 11.0-mig-base_exception


Please do not forget to remove this.

Rule should only count available stock from selected warehouse from sale order. Without warehouse in context, it currently sums all stock available in all warehouses.

The previous parent menu has an action attached, and with these modules, it can't be clicked.

* [FIX] sale_exception confirm wizard * [FIX] add test of test_all_draft_orders & flake8 & readme.rst * [FIX] improve codecov test * [FIX] delete odl translation * [FIX] add Camptocamp to author * [FIX] readme.rst

Raise SingletonError when you have a recordset with multiple sale order. This restore the capability to write on multiple sale.order

StefanRijnhart · 2017-12-06T09:02:11Z

Travis no like :-(

2017-12-05 16:25:17,964 5514 ERROR openerp_test odoo.modules.registry: Model base.exception.test.purchase.line has no table.
2017-12-05 16:25:17,964 5514 ERROR openerp_test odoo.modules.registry: Model base.exception.test.purchase has no table.

simahawk · 2017-12-06T09:40:38Z

I know. I'll get back on this later. Anyway the error is related to base_exception that has been merged into server-tools w/out build issues (as far as I see).

Ahh, I guess that it's because the test models are registered only w/ --test-enable or ODOO_TEST_ENABLE env var. But, modules from other repos are installed "normally".
So, it works on server-tools branch but not here 😢

simahawk · 2017-12-06T10:01:04Z

It's really strange because on runbot is not failing and the base module is installed as well w/out test enabled:

/home/odoo/OCB-11.0/odoo-bin -d openerp_template --log-level=info --stop-after-init --init base_exception,sale,base

On travis I see:

 /home/travis/OCB-11.0/odoo-bin -d openerp_test --db-filter=^openerp_test$ --stop-after-init --log-level info --log-handler openerp.tools.yaml_import:DEBUG --test-enable --init sale_exception

Maybe is due to the fact that those models are inside tests folder 🤔

mourad-ehm · 2017-12-06T11:57:34Z

I had a same problem with purchase exception OCA/purchase-workflow#467

simahawk · 2017-12-06T12:00:32Z

@mourad-ehm I think is because of this OCA/server-tools#1025 (comment)
That's one of the reason why I usually put them into models/.

JordiBForgeFlow · 2017-12-28T17:29:44Z

@simahawk PR OCA/server-tools#1111 fixes the problem in base_exception

simahawk · 2018-01-12T09:02:28Z

@jbeficent test fixed, thank ;)
@lreficent oca deps updated.
@pedrobaeza ready for another review and merge? 😉

ghost

LGTM
micro remarks

ghost · 2018-01-16T08:44:24Z

sale_exception/__init__.py

@@ -0,0 +1,3 @@
+# -*- coding: utf-8 -*-


can be removed

ghost · 2018-01-16T08:44:47Z

sale_exception/__manifest__.py

@@ -0,0 +1,19 @@
+# -*- coding: utf-8 -*-


can be removed too

ghost · 2018-01-16T08:53:55Z

sale_exception/models/__init__.py

@@ -0,0 +1,2 @@
+# -*- coding: utf-8 -*-


can be removed

ghost · 2018-01-16T08:54:04Z

sale_exception/models/sale.py

@@ -0,0 +1,72 @@
+# -*- coding: utf-8 -*-


ghost · 2018-01-16T08:54:19Z

sale_exception/models/sale.py

@@ -0,0 +1,72 @@
+# -*- coding: utf-8 -*-
+# Copyright 2011 Akretion, Camptocamp, Sodexis
+# Copyright 2017 Akretion, Camptocamp


ghost · 2018-01-16T09:00:35Z

sale_exception/tests/test_sale_exception.py

@@ -0,0 +1,94 @@
+# -*- coding: utf-8 -*-


ghost · 2018-01-16T09:01:37Z

sale_exception/tests/test_sale_exception.py

@@ -0,0 +1,94 @@
+# -*- coding: utf-8 -*-
+# Copyright 2011 Akretion, Camptocamp, Sodexis
+# Copyright 2017 Akretion, Camptocamp


ghost · 2018-01-16T09:02:41Z

sale_exception/wizard/__init__.py

@@ -0,0 +1,2 @@
+# -*- coding: utf-8 -*-


can be removed

ghost · 2018-01-16T09:02:51Z

sale_exception/wizard/sale_exception_confirm.py

@@ -0,0 +1,19 @@
+# -*- coding: utf-8 -*-


ghost · 2018-01-16T09:02:58Z

sale_exception/wizard/sale_exception_confirm.py

@@ -0,0 +1,19 @@
+# -*- coding: utf-8 -*-
+# Copyright 2011 Akretion, Camptocamp, Sodexis
+# Copyright 2017 Akretion, Camptocamp


simahawk · 2018-01-16T09:31:27Z

@OleksandrPaziuk tnx! all comments addressed.

ghost

Great work!

leemannd · 2018-01-16T10:56:24Z

sale_exception/wizard/sale_exception_confirm.py

+
+    @api.multi
+    def action_confirm(self):
+        self.ensure_one()


Question, self.ensure_one() in multi ? Do we want to be able to call the wizard on multiple SO ?

It's a button on a wizard: you won't use it on multiple SO and in any case you can relate only one SO per wiz, so... :)

It's upstream API https://github.com/OCA/server-tools/blob/11.0/base_exception/wizard/base_exception_confirm.py#L38

leemannd

I have only one question before approval

simahawk · 2018-01-16T11:17:40Z

@StefanRijnhart tnx for reviewing: can you hit the button? 😜

StefanRijnhart · 2018-01-16T11:35:06Z

I hit that big and powerful button, and it worked.

atchuthan and others added 2 commits November 28, 2017 16:49

[ADD] sale_exception

9799d5d

[FIX] sale_exception: README

28a37c6

simahawk mentioned this pull request Nov 28, 2017

Migration to version 11.0 #538

Closed

65 tasks

pedrobaeza added this to the 11.0 milestone Nov 28, 2017

simahawk force-pushed the 11-mig-sale_exception branch from a5cec45 to d766a9d Compare November 29, 2017 10:03

StefanRijnhart approved these changes Dec 1, 2017

View reviewed changes

simahawk force-pushed the 11-mig-sale_exception branch from a6df178 to 57507fb Compare December 1, 2017 22:57

LoisRForgeFlow suggested changes Dec 5, 2017

View reviewed changes

atchuthan and others added 7 commits December 5, 2017 17:16

[FIX] sale_exception: configuration menu

b1579c2

[IMP] Rename action_cancel to action_draft to reset the flag

4c7d164

[FIX] sale_exception: count stock from selected warehouse

071edce

Rule should only count available stock from selected warehouse from sale order. Without warehouse in context, it currently sums all stock available in all warehouses.

sale_*: Fix parent menu

63643ae

The previous parent menu has an action attached, and with these modules, it can't be clicked.

[FIX] add dependency to server-tools/base_exception

753ffa7

[FIX] sale_exception misc

0d22a61

* [FIX] sale_exception confirm wizard * [FIX] add test of test_all_draft_orders & flake8 & readme.rst * [FIX] improve codecov test * [FIX] delete odl translation * [FIX] add Camptocamp to author * [FIX] readme.rst

[FIX] sale_exception constraint

5b42371

Raise SingletonError when you have a recordset with multiple sale order. This restore the capability to write on multiple sale.order

simahawk force-pushed the 11-mig-sale_exception branch from 57507fb to b433f80 Compare December 5, 2017 16:20

simahawk mentioned this pull request Dec 6, 2017

11.0 mig base exception OCA/server-tools#1025

Merged

simahawk force-pushed the 11-mig-sale_exception branch from 761f790 to 7f50c72 Compare January 12, 2018 07:58

simahawk force-pushed the 11-mig-sale_exception branch 3 times, most recently from cef2b0c to 1acac57 Compare January 12, 2018 08:27

ghost reviewed Jan 16, 2018

View reviewed changes

simahawk force-pushed the 11-mig-sale_exception branch from 1acac57 to e747319 Compare January 16, 2018 09:30

simahawk added 2 commits January 16, 2018 10:30

[11.0][MIG] sale_exception

3792d2f

sale_exception: recover translations from v10

b032493

simahawk force-pushed the 11-mig-sale_exception branch from e747319 to b032493 Compare January 16, 2018 09:31

ghost approved these changes Jan 16, 2018

View reviewed changes

StefanRijnhart approved these changes Jan 16, 2018

View reviewed changes

leemannd reviewed Jan 16, 2018

View reviewed changes

StefanRijnhart merged commit a6aa6b9 into OCA:11.0 Jan 16, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[11.0][MIG] sale_exception #576

[11.0][MIG] sale_exception #576

simahawk commented Nov 28, 2017

simahawk commented Nov 28, 2017

pedrobaeza commented Nov 28, 2017

simahawk commented Nov 28, 2017

simahawk commented Nov 29, 2017

pedrobaeza commented Nov 29, 2017

simahawk commented Nov 29, 2017

StefanRijnhart left a comment

LoisRForgeFlow Dec 5, 2017

StefanRijnhart commented Dec 6, 2017

simahawk commented Dec 6, 2017 •

edited

Loading

simahawk commented Dec 6, 2017

mourad-ehm commented Dec 6, 2017

simahawk commented Dec 6, 2017

JordiBForgeFlow commented Dec 28, 2017

simahawk commented Jan 12, 2018

ghost left a comment

ghost Jan 16, 2018

ghost Jan 16, 2018

ghost Jan 16, 2018

ghost Jan 16, 2018

ghost Jan 16, 2018

ghost Jan 16, 2018

ghost Jan 16, 2018

ghost Jan 16, 2018

ghost Jan 16, 2018

ghost Jan 16, 2018

simahawk commented Jan 16, 2018

ghost left a comment

leemannd Jan 16, 2018

simahawk Jan 16, 2018

StefanRijnhart Jan 16, 2018

leemannd left a comment

simahawk commented Jan 16, 2018

StefanRijnhart commented Jan 16, 2018

		@@ -0,0 +1,2 @@
		# base_exception v11 https://github.com/OCA/server-tools/pull/1025
		server-tools https://github.com/akretion/server-tools 11.0-mig-base_exception

[11.0][MIG] sale_exception #576

[11.0][MIG] sale_exception #576

Conversation

simahawk commented Nov 28, 2017

simahawk commented Nov 28, 2017

pedrobaeza commented Nov 28, 2017

simahawk commented Nov 28, 2017

simahawk commented Nov 29, 2017

pedrobaeza commented Nov 29, 2017

simahawk commented Nov 29, 2017

StefanRijnhart left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

StefanRijnhart commented Dec 6, 2017

simahawk commented Dec 6, 2017 • edited Loading

simahawk commented Dec 6, 2017

mourad-ehm commented Dec 6, 2017

simahawk commented Dec 6, 2017

JordiBForgeFlow commented Dec 28, 2017

simahawk commented Jan 12, 2018

ghost left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

simahawk commented Jan 16, 2018

ghost left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

leemannd left a comment

Choose a reason for hiding this comment

simahawk commented Jan 16, 2018

StefanRijnhart commented Jan 16, 2018

simahawk commented Dec 6, 2017 •

edited

Loading