[11.0][purchase_exception] small fixes #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
Codecov Report
@@ Coverage Diff @@
## 11.0-add-purchase_exception #5 +/- ##
==========================================================
Coverage 100% 100%
==========================================================
Files 2 2
Lines 46 50 +4
==========================================================
+ Hits 46 50 +4
Continue to review full report at Codecov.
|
mourad-ehm
reviewed
Nov 23, 2017
| @@ -15,5 +15,7 @@ class PurchaseExceptionConfirm(models.TransientModel): | |||
| def action_confirm(self): | |||
| self.ensure_one() | |||
| if self.ignore: | |||
| self.related_model_id.button_draft() | |||
There was a problem hiding this comment.
Why you execute button_draft before the confirm ?
There was a problem hiding this comment.
Because button_confirm() only works from status 'draft', and you still want the logic https://github.com/odoo/odoo/blob/11.0/addons/purchase/models/purchase.py#L346 to be executed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some small fixes that I detected during my testing.