Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[13.0][FIX] l10n_ch_base_bank #603

Merged
merged 2 commits into from
Apr 14, 2021
Merged

[13.0][FIX] l10n_ch_base_bank #603

merged 2 commits into from
Apr 14, 2021

Conversation

TDu
Copy link
Member

@TDu TDu commented Mar 19, 2021

On an unrelated PR the test for l10n_ch_base_bank were broken.
It seems to be related to this new change introduced by

Which test the valid of the type journal.

So this fixes the test, but I am not sure if they are still meaningfull.

On an unrelated PR the test for l10n_ch_base_bank were broken.
It seems to be related to this new change introduced by

* odoo/odoo#67599

Which test the valid of the type journal.

So this fixes the test, but I am not sure if they are still meaningfull.
@TDu TDu mentioned this pull request Mar 19, 2021
Copy link
Member

@yvaucher yvaucher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is the fix in test_search_invoice different than in test_create_invoice ?

@TDu
Copy link
Member Author

TDu commented Mar 30, 2021

Why is the fix in test_search_invoice different than in test_create_invoice ?

Well both test file started different. One created a res.partner.bank and the other not.
I have change them so they prepare the environment in the same way.

@TDu
Copy link
Member Author

TDu commented Apr 14, 2021

@yvaucher Do you want to have another look at this ?
It could probably fix master that is red.

@yvaucher yvaucher merged commit ccd40b5 into OCA:13.0 Apr 14, 2021
SimoneVagile pushed a commit to SimoneVagile/l10n-switzerland that referenced this pull request Aug 27, 2021
* [13.0][FIX] l10n_ch_base_bank

On an unrelated PR the test for l10n_ch_base_bank were broken.
It seems to be related to this new change introduced by

* odoo/odoo#67599

Which test the valid of the type journal.

So this fixes the test, but I am not sure if they are still meaningfull.
TDu added a commit to camptocamp/l10n-switzerland that referenced this pull request Sep 9, 2021
This is a forward port of

* OCA#603

On an unrelated PR the test for l10n_ch_base_bank were broken.
It seems to be related to this new change introduced by

* odoo/odoo#67599

Which test the valid of the type journal.

So this fixes the test, but I am not sure if they are still meaningfull.
sonhd91 pushed a commit to sonhd91/l10n-switzerland that referenced this pull request Oct 5, 2021
This is a forward port of

* OCA#603

On an unrelated PR the test for l10n_ch_base_bank were broken.
It seems to be related to this new change introduced by

* odoo/odoo#67599

Which test the valid of the type journal.

So this fixes the test, but I am not sure if they are still meaningfull.
sonhd91 pushed a commit to sonhd91/l10n-switzerland that referenced this pull request Oct 5, 2021
This is a forward port of

* OCA#603

On an unrelated PR the test for l10n_ch_base_bank were broken.
It seems to be related to this new change introduced by

* odoo/odoo#67599

Which test the valid of the type journal.

So this fixes the test, but I am not sure if they are still meaningfull.
sonhd91 pushed a commit to sonhd91/l10n-switzerland that referenced this pull request Jul 4, 2022
This is a forward port of

* OCA#603

On an unrelated PR the test for l10n_ch_base_bank were broken.
It seems to be related to this new change introduced by

* odoo/odoo#67599

Which test the valid of the type journal.

So this fixes the test, but I am not sure if they are still meaningfull.
ivantodorovich pushed a commit to camptocamp/l10n-switzerland that referenced this pull request Jan 4, 2023
This is a forward port of

* OCA#603

On an unrelated PR the test for l10n_ch_base_bank were broken.
It seems to be related to this new change introduced by

* odoo/odoo#67599

Which test the valid of the type journal.

So this fixes the test, but I am not sure if they are still meaningfull.
ivantodorovich pushed a commit to camptocamp/l10n-switzerland that referenced this pull request Jan 4, 2023
This is a forward port of

* OCA#603

On an unrelated PR the test for l10n_ch_base_bank were broken.
It seems to be related to this new change introduced by

* odoo/odoo#67599

Which test the valid of the type journal.

So this fixes the test, but I am not sure if they are still meaningfull.
sonhd91 pushed a commit to sonhd91/l10n-switzerland that referenced this pull request Jan 9, 2023
This is a forward port of

* OCA#603

On an unrelated PR the test for l10n_ch_base_bank were broken.
It seems to be related to this new change introduced by

* odoo/odoo#67599

Which test the valid of the type journal.

So this fixes the test, but I am not sure if they are still meaningfull.
nguyenminhchien pushed a commit to nguyenminhchien/l10n-switzerland that referenced this pull request Mar 25, 2024
This is a forward port of

* OCA#603

On an unrelated PR the test for l10n_ch_base_bank were broken.
It seems to be related to this new change introduced by

* odoo/odoo#67599

Which test the valid of the type journal.

So this fixes the test, but I am not sure if they are still meaningfull.
BT-anieto pushed a commit to BT-anieto/l10n-switzerland that referenced this pull request Jun 11, 2024
This is a forward port of

* OCA#603

On an unrelated PR the test for l10n_ch_base_bank were broken.
It seems to be related to this new change introduced by

* odoo/odoo#67599

Which test the valid of the type journal.

So this fixes the test, but I am not sure if they are still meaningfull.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants