[13.0][ADD] ebill_paynet v2 #585

TDu · 2021-02-08T11:17:01Z

This is to followup on #551.That PR included the ebill_paynet_account_financial_discount which needs to be open on its own #586.
And also the server_env PR #559 related to paynet is now included here.

yvaucher

To be coherent with other module, please use the english term ISR and not ESR.

We changed from BVR to ISR to have less mixed terms, so always prefer ISR when possible. I suppose that the xml tags can only be ESR du to the ebill standard, but in Odoo all displayed values must be ISR.

ebill_paynet/models/ebill_payment_contract.py

ebill_paynet/models/paynet_invoice_message.py

ebill_paynet/messages/invoice-2003A.xml

ebill_paynet/models/account_invoice.py

yvaucher · 2021-02-23T14:41:06Z

ebill_paynet/messages/invoice-2013A.xml

+        {%- if invoice.company_id.vat %}
+        <Tax-No>{{ invoice.company_id.vat }}</Tax-No>
+        {%- endif %}
+        {%- if invoice_esr %}


Suggested change

{%- if invoice_esr %}

{%- if invoice_isr %}

Where does come this value? I don't see it anywhere.

Same than below

yvaucher · 2021-02-23T14:41:18Z

ebill_paynet/messages/invoice-2013A.xml

+        <Tax-No>{{ invoice.company_id.vat }}</Tax-No>
+        {%- endif %}
+        {%- if invoice_esr %}
+            <Doc-Reference Type="ESR-NEU">{{ invoice_esr }}</Doc-Reference>


Suggested change

<Doc-Reference Type="ESR-NEU">{{ invoice_esr }}</Doc-Reference>

<Doc-Reference Type="ESR-NEU">{{ invoice_isr }}</Doc-Reference>

This file is related to Paynet B2C service and is not implemented yet but kept for further reference

yvaucher · 2021-02-23T14:51:43Z

ebill_paynet/models/paynet_invoice_message.py

+        selection=[("qr", "QR"), ("esr", "ESR"), ("esp", "ESP"), ("npy", "NPY")],
+        default="qr",
+        readonly=True,
+    )


a help text could help to give the full names of QR, ISR, ESP and NPY (I have no idea what the 2 latest are)

ebill_paynet/models/paynet_invoice_message.py

TDu · 2021-03-18T07:35:52Z

@yvaucher I did the changes regarding the naming of esr/isr.
But the build is red and it seems to be related to another module, would you have any idea why ? Changes in the core ?

TDu · 2021-03-19T07:23:38Z

@yvaucher Regarding the broken tests, I opened this #603

ebill_paynet/__manifest__.py

yvaucher · 2021-08-05T08:17:10Z

some rebase to do

This is migrated from the previous implementation for 12.0

Remove compute on user and password Improve tree view for messages

Before one job was polling for shipment and downloading/acknowledging them. This could lead to incoherent state between Odoo and the distant server. Now one job polls for shipment and creates one job for each new shipment to be downloaded and parsed. Also add improvement in the UI.

@sebalix

Fix the selection of the bank account of the sale order when paynet transmit method is choosen. Fix the get_active contract that has been moved to base_ebill_payment_contract. Add some fixes proposed by @sebalix. Some improvements and fixes on invoice message generation : * Fix the payment reference (it was using the old field pre v13) * Allow to have a 2nd line in the biller name node, it uses the company_name_suffix_1 on the company partner for it. * Change the customer reference for the purchase linked to the invoice. * Improve or so I hope the account number if it is a postal account the specific account number is used otherwise we use the bic.

Implement the QR invoice functionality from SIX specifications. Add on the ebill contract the choice of payment ESR or QR, so it can be specific for each customer. The XML payload has been updated. And the PDF data included improved, so the correct PDF is generated depending of the type of payment.

Add the price and tax node for each line item. Improve the reference on the sale order. Add sale as a dependency and improve the tests by generating the invoice from a sale order.

Fix naming of eBill Improve import statement of zeep

The specifcation accepts only one tax node by line.

The `l10n_ch_postal` field is used for bank account not belonging to the company (like suppliers). The `l10n_ch_isr_subscription_chf` field is the one used for bank account belonging to the company.

The actual invoice and the payment (ESR, QR) reports are not generated together in one PDF so up to know only the page with the payment was sent to Paynet. Now both report are merge and sent to the system.

Having this field stored will create problems for implementation that uses different stacks (integration/production) And it is not required

Fix some line with a limited length of 35 char. Round some decimal.

Use the partner_shipping_id information for the DELIVERY-PARTY node. Also for all name nodes concerning a res.partner record, add a Line node with the commercial company name if it is different to the partner name.

When downloading a shipment if a fault occurs on the communication with the DWS. The module was trying to parse a content set to None. So the exception must be raised and the information on the error will be available in the job result. Comment answered ;) and removed.

Remove invoice line with a display_type value. The filtering can be overriden, if needed. Handle properly the invoice line not linked to a product. Fix some falsy values. Run pre-commit hooks

Reading the specs it seemed to be the other way around. But it has been confirmed by someone at SIX. That the reference for linked sale order must be the customer order reference.

Use the currency of the invoice to generated the message instead of fixing it to CHF. Fix the length of a name

The payment term node in the Paynet message allows to add a discount information in case of payment until a certain date. As this feature does not exist in the standard implementation of Odoo, this is extracted into another module, to give the option to use different implementation for it. See `ebill_paynet_account_financial_discount` for one of them.

This fixes an issue when downloading a shipment from the DWS, while using a production account.

The module l10n_ch_qr has been renamed to l10n_ch_qriban. For this to work with an updated Odoo src the following PR is required: * odoo/odoo#57710

Add a module to allow configuration of paynet.service with the aid of server environment.

Adds hooks for interaction with other module. One for the sale order customer reference. And another one for managing <OTHER-REFERENCE> node.

TDu · 2021-09-23T12:49:18Z

It has been rebased.

TDu · 2021-09-23T12:55:56Z

@yvaucher Rebased done, and Travis is 💚

simahawk

LG overall. Could you add to ROADMAP "consider refactoring on top of EDI framework for v14 or v15"?

simahawk · 2021-09-23T13:17:21Z

ebill_paynet/components/api.py

@@ -0,0 +1,58 @@
+# Copyright 2019 Camptocamp SA


why components if there's no component here?

No components in the sense of https://github.com/OCA/connector/tree/13.0/component, true.

TDu · 2021-09-23T13:43:39Z

LG overall. Could you add to ROADMAP "consider refactoring on top of EDI framework for v14 or v15"?

Done

This was referenced Feb 8, 2021

[13.0][MIG] ebill_paynet #551

Closed

[13.0][ADD] server_env_ebill_paynet #559

Closed

TDu force-pushed the paynet13v2 branch from a44a0d7 to a91b8a5 Compare February 16, 2021 08:02

yvaucher requested changes Feb 23, 2021

View reviewed changes

yvaucher reviewed Feb 23, 2021

View reviewed changes

ebill_paynet/models/paynet_invoice_message.py Outdated Show resolved Hide resolved

yvaucher added the needs fixing label Feb 23, 2021

TDu force-pushed the paynet13v2 branch from 7dac106 to 9960ed1 Compare March 25, 2021 08:28

simahawk reviewed Mar 26, 2021

View reviewed changes

ebill_paynet/__manifest__.py Show resolved Hide resolved

TDu added 18 commits September 23, 2021 14:10

[13.0][ADD] ebill_paynet module

ab73d7b

This is migrated from the previous implementation for 12.0

Paynet: add interfacing with account_invoice_export

ca5f50d

Remove compute on user and password Improve tree view for messages

[13.0][IMP] ebiil_paynet B2B message

9ca5a64

Add the price and tax node for each line item. Improve the reference on the sale order. Add sale as a dependency and improve the tests by generating the invoice from a sale order.

[13.0][IMP] ebiil_paynet

93c618e

Fix naming of eBill Improve import statement of zeep

[13.0][IMP] ebiil_paynet B2B message fix tax on line

b1c9ef5

The specifcation accepts only one tax node by line.

[13.0][FIX] ebiil_paynet - ESR bank account

bf7bd1e

The `l10n_ch_postal` field is used for bank account not belonging to the company (like suppliers). The `l10n_ch_isr_subscription_chf` field is the one used for bank account belonging to the company.

[13.0][IMP] ebill_paynet - Pdf sent

041e68b

The actual invoice and the payment (ESR, QR) reports are not generated together in one PDF so up to know only the page with the payment was sent to Paynet. Now both report are merge and sent to the system.

Fix url computed field on paynet service

1d6bc65

Having this field stored will create problems for implementation that uses different stacks (integration/production) And it is not required

Fix paynet message generation

dbd9612

Fix some line with a limited length of 35 char. Round some decimal.

Paynet fix the delivery address and party name

0dcb692

Use the partner_shipping_id information for the DELIVERY-PARTY node. Also for all name nodes concerning a res.partner record, add a Line node with the commercial company name if it is different to the partner name.

Paynet fix invoicing line generated in XML

69cd1cc

Remove invoice line with a display_type value. The filtering can be overriden, if needed. Handle properly the invoice line not linked to a product. Fix some falsy values. Run pre-commit hooks

Paynet switch Odoo order ref with customer order ref

2daf164

Reading the specs it seemed to be the other way around. But it has been confirmed by someone at SIX. That the reference for linked sale order must be the customer order reference.

Paynet improve invoice currency and fix data length

ee53222

Use the currency of the invoice to generated the message instead of fixing it to CHF. Fix the length of a name

Fix the due date in the Paynet message

98221cc

TDu and others added 14 commits September 23, 2021 14:11

Fix XML node content length with truncate

7807459

Fix paynet communication with prod service

7946f44

This fixes an issue when downloading a shipment from the DWS, while using a production account.

Fix module dependencies

664e17c

The module l10n_ch_qr has been renamed to l10n_ch_qriban. For this to work with an updated Odoo src the following PR is required: * odoo/odoo#57710

[FIX] remove customer fields (#3)

f39538a

[13.0][ADD] server_env_ebill_paynet

f96d80e

Add a module to allow configuration of paynet.service with the aid of server environment.

ebill_paynet: Change import statement for zeep

ba17373

ebill_paynet: Fix travis for pdf generated

8471c5d

ebill_paynet: Add hook for other reference on invoice

c32cea2

Adds hooks for interaction with other module. One for the sale order customer reference. And another one for managing <OTHER-REFERENCE> node.

Fix ISR terminology and add translation

83820fc

Add delivery note in XML message Paynet

4da44b1

Fix transmit method data

5c4bd3d

Paynet add extended amount

9439060

ebill_paynet: make amount type 66 tax excluded (#5)

44baba8

TDu force-pushed the paynet13v2 branch from 27ca699 to 44baba8 Compare September 23, 2021 12:12

simahawk approved these changes Sep 23, 2021

View reviewed changes

TDu added 2 commits September 23, 2021 15:43

Fix linting and add info in roadmap

a1c9ecc

Paynet fix python requirements

5d8b2dc

TDu force-pushed the paynet13v2 branch from 78c7e94 to 5d8b2dc Compare September 23, 2021 13:43

yvaucher approved these changes Sep 27, 2021

View reviewed changes

yvaucher merged commit b456b3a into OCA:13.0 Sep 27, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[13.0][ADD] ebill_paynet v2 #585

[13.0][ADD] ebill_paynet v2 #585

TDu commented Feb 8, 2021 •

edited

Loading

yvaucher left a comment

yvaucher Feb 23, 2021

yvaucher Feb 23, 2021

TDu Mar 15, 2021

yvaucher Feb 23, 2021

TDu Mar 15, 2021

yvaucher Feb 23, 2021

TDu commented Mar 18, 2021

TDu commented Mar 19, 2021

yvaucher commented Aug 5, 2021

TDu commented Sep 23, 2021

TDu commented Sep 23, 2021

simahawk left a comment

simahawk Sep 23, 2021

TDu Sep 23, 2021

TDu commented Sep 23, 2021

	<Doc-Reference Type="ESR-NEU">{{ invoice_esr }}</Doc-Reference>
	<Doc-Reference Type="ESR-NEU">{{ invoice_isr }}</Doc-Reference>

[13.0][ADD] ebill_paynet v2 #585

[13.0][ADD] ebill_paynet v2 #585

Conversation

TDu commented Feb 8, 2021 • edited Loading

yvaucher left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

TDu commented Mar 18, 2021

TDu commented Mar 19, 2021

yvaucher commented Aug 5, 2021

TDu commented Sep 23, 2021

TDu commented Sep 23, 2021

simahawk left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

TDu commented Sep 23, 2021

TDu commented Feb 8, 2021 •

edited

Loading