Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[24.05] python3Packages.js2py: remove usage in other packages #351479

Merged
merged 1 commit into from
Oct 27, 2024

Conversation

samueltardieu
Copy link
Contributor

(cherry picked from commit 0f79dd4)

Manual backport of #349550

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@wegank wegank added 12.approvals: 1 This PR was reviewed and approved by one reputable person 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package labels Oct 26, 2024
Copy link
Contributor

@ruby0b ruby0b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pyload-ng build failure now no longer tells you that the reason is the vulnerability but that's probably fine

@tomodachi94
Copy link
Member

tomodachi94 commented Oct 26, 2024

I'm not sure this is acceptable as-is for a release, given that this removes a package (a breaking change). Maybe we should just remove the uses of the package, but leave the package intact?

c.f. https://github.com/NixOS/nixpkgs/blob/master/CONTRIBUTING.md#changes-acceptable-for-releases

Copy link
Member

@tomodachi94 tomodachi94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mweinelt mweinelt marked this pull request as draft October 27, 2024 01:06
@samueltardieu
Copy link
Contributor Author

Makes sense. I've amended the PR to not remove js2py itself.

@samueltardieu samueltardieu marked this pull request as ready for review October 27, 2024 01:16
@samueltardieu samueltardieu changed the title [24.05] python3Packages.js2py: remove [24.05] python3Packages.js2py: remove usage in other packages Oct 27, 2024
Copy link
Member

@tomodachi94 tomodachi94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes lgtm, let's wait for Ofborg and then we can merge this.

@ofborg ofborg bot requested review from ambroisie and ruby0b October 27, 2024 03:16
@tomodachi94 tomodachi94 merged commit 46c4646 into NixOS:release-24.05 Oct 27, 2024
27 of 29 checks passed
@tomodachi94
Copy link
Member

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: python 8.has: clean-up 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 12.approvals: 1 This PR was reviewed and approved by one reputable person 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants