-
-
Notifications
You must be signed in to change notification settings - Fork 14.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[24.05] python3Packages.js2py: remove usage in other packages #351479
[24.05] python3Packages.js2py: remove usage in other packages #351479
Conversation
e1413e9
to
0b14357
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pyload-ng build failure now no longer tells you that the reason is the vulnerability but that's probably fine
I'm not sure this is acceptable as-is for a release, given that this removes a package (a breaking change). Maybe we should just remove the uses of the package, but leave the package intact? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
unmaintained and insecure: https://github.com/Marven11/CVE-2024-28397-js2py-Sandbox-Escape (cherry picked from commit 0f79dd4)
0b14357
to
be9562c
Compare
Makes sense. I've amended the PR to not remove js2py itself. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes lgtm, let's wait for Ofborg and then we can merge this.
Thank you! |
(cherry picked from commit 0f79dd4)
Manual backport of #349550
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.