Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python3Packages.js2py: remove #349550

Merged
merged 1 commit into from
Oct 19, 2024
Merged

python3Packages.js2py: remove #349550

merged 1 commit into from
Oct 19, 2024

Conversation

ruby0b
Copy link
Contributor

@ruby0b ruby0b commented Oct 18, 2024

#348943

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@ruby0b ruby0b mentioned this pull request Oct 18, 2024
Merged
13 tasks
@nix-owners nix-owners bot requested a review from natsukium October 18, 2024 15:06
emilazy
emilazy requested changes Oct 18, 2024
View reviewed changes
Copy link
Member

@emilazy emilazy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for tackling this!

The comment/passthru stuff in pyjsparser should be cleaned up. Maybe there’s a subset of tests we can run without js2py?

@ruby0b
Copy link
Contributor Author

ruby0b commented Oct 18, 2024

Looks like pyjsparser's tests all use js2py unfortunately

@ofborg ofborg bot added 8.has: clean-up 8.has: package (new) This PR adds a new package labels Oct 18, 2024
@ofborg ofborg bot requested review from ambroisie and pacien October 18, 2024 16:47
natsukium
natsukium approved these changes Oct 19, 2024
View reviewed changes
Copy link
Member

@natsukium natsukium left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@natsukium
Copy link
Member

Result of nixpkgs-review pr 349550 at 0f79dd4 run on x86_64-linux 1

❌ 3 packages failed to build:
✅ 3 packages built:
  • pyload-ng
  • python311Packages.django-js-reverse
  • python312Packages.django-js-reverse

emilazy
emilazy approved these changes Oct 19, 2024
View reviewed changes
Copy link
Member

@emilazy emilazy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

jupysql failure looks unrelated. Thanks for tackling this!

@emilazy emilazy merged commit a6de179 into NixOS:master Oct 19, 2024
28 checks passed
@samueltardieu samueltardieu mentioned this pull request Oct 26, 2024
Merged
13 tasks
tomodachi94 added a commit that referenced this pull request Oct 27, 2024
@tomodachi94
[24.05] python3Packages.js2py: remove usage in other packages (#351479)
46c4646 
Backport of #349550
@tomodachi94 tomodachi94 added the 8.has: port to stable A PR already has a backport to the stable release. label Oct 27, 2024
@SuperSandro2000 SuperSandro2000 mentioned this pull request Oct 29, 2024
Open
13 tasks
@ruby0b ruby0b mentioned this pull request Nov 7, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@natsukium natsukium natsukium approved these changes

@emilazy emilazy emilazy approved these changes

@ambroisie ambroisie Awaiting requested review from ambroisie

@pacien pacien Awaiting requested review from pacien

Assignees
No one assigned
Labels
6.topic: python 8.has: clean-up 8.has: package (new) This PR adds a new package 8.has: port to stable A PR already has a backport to the stable release. 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ruby0b @natsukium @emilazy @tomodachi94