Skip to content

Commit

Permalink
[24.05] python3Packages.js2py: remove usage in other packages (#351479)
Browse files Browse the repository at this point in the history
Backport of #349550
  • Loading branch information
tomodachi94 authored Oct 27, 2024
2 parents cd3e883 + be9562c commit 46c4646
Show file tree
Hide file tree
Showing 4 changed files with 5 additions and 13 deletions.
1 change: 0 additions & 1 deletion pkgs/applications/networking/pyload-ng/default.nix
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,6 @@ python3.pkgs.buildPythonApplication rec {
flask-compress
flask-session
flask-themes2
js2py
pycurl
semver
setuptools
Expand Down
5 changes: 3 additions & 2 deletions pkgs/development/python-modules/django-js-reverse/default.nix
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@
django,
packaging,
nodejs,
js2py,
six,
}:

Expand All @@ -26,9 +25,11 @@ buildPythonPackage rec {

propagatedBuildInputs = [ django ] ++ lib.optionals (pythonAtLeast "3.7") [ packaging ];

# Js2py is needed for tests but it's unmaintained and insecure
doCheck = false;

nativeCheckInputs = [
nodejs
js2py
six
];

Expand Down
2 changes: 1 addition & 1 deletion pkgs/development/python-modules/lark/default.nix
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ buildPythonPackage rec {
"lark.grammars"
];

# Js2py is needed for tests but it's marked as insecure
# Js2py is needed for tests but it's unmaintained and insecure
doCheck = false;

meta = with lib; {
Expand Down
10 changes: 1 addition & 9 deletions pkgs/development/python-modules/pyjsparser/default.nix
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@
fetchFromGitHub,
buildPythonPackage,
pytestCheckHook,
js2py,
}:

let
Expand All @@ -21,18 +20,11 @@ let

nativeCheckInputs = [
pytestCheckHook
js2py
];

# escape infinite recursion with js2py
# js2py is needed for tests but it's unmaintained and insecure
doCheck = false;

passthru.tests = {
check = pyjsparser.overridePythonAttrs (_: {
doCheck = true;
});
};

pythonImportsCheck = [ "pyjsparser" ];

meta = with lib; {
Expand Down

0 comments on commit 46c4646

Please sign in to comment.