python310Packages.buildPythonPackage: introduce pyproject option #254136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
ofborg
bot
added
11.by: package-maintainer
|
The documentation here needs some love |
github-actions
bot
added
the
8.has: documentation
replaced all the |
FRidh
reviewed
Sep 9, 2023
| * `pyproject`: Whether the pyproject format should be used. When set to `true`, | ||
| `pypaBuildHook` will be used, and you can add the required build dependencies | ||
| from `build-system.requires` to `nativeBuildInputs`. Note that the pyproject | ||
| format falls back to using `setuptools`, so you can use `pyproject = true` |
There was a problem hiding this comment.
How? setuptools is not supposed to be available by default.
There was a problem hiding this comment.
by that I mean pypaBuildHook will try to use setuptools even if pyproject.toml doesn't exist, but it still needs to be added to nativeBuildInputs
|
fixed merge conflicts |
Mic92
approved these changes
Sep 13, 2023
delroth
added
the
12.approvals: 1
This was referenced Nov 20, 2023
13 tasks
This was referenced Dec 27, 2023
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
#253154
adds the
pyprojectoption that conflicts withformat, wherepyproject = trueis equivalent toformat = "pyproject", andpyproject = falseis equivalent toformat = "other", and 3 more commits to demonstrate the conversion offormat = "pyproject" | "setuptools" | "other"to thepyprojectoptionThings done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)