Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rare: 1.10.3 -> 1.10.7 #272763

Merged
merged 1 commit into from
Dec 11, 2023
Merged

rare: 1.10.3 -> 1.10.7 #272763

merged 1 commit into from
Dec 11, 2023

Conversation

MultisampledNight
Copy link
Member

@MultisampledNight MultisampledNight commented Dec 7, 2023

Description of changes

Note that it still prints 1.10.3 on the command line, while actually 1.10.6 is in use. This'll be the case until RareDevs/Rare#328 is merged and published in a future release. I didn't update the hash in an earlier version of this PR, sorry.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@ofborg ofborg bot requested a review from WolfangAukang December 7, 2023 23:13
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 labels Dec 7, 2023
@MultisampledNight
Copy link
Member Author

(Updated the hash, left it unchanged before by accident which caused the old source to be pulled.)

pkgs/games/rare/default.nix Outdated Show resolved Hide resolved
pkgs/games/rare/default.nix Show resolved Hide resolved
pkgs/games/rare/default.nix Outdated Show resolved Hide resolved
pkgs/games/rare/default.nix Show resolved Hide resolved
@MultisampledNight MultisampledNight marked this pull request as draft December 10, 2023 12:20
@MultisampledNight
Copy link
Member Author

1.10.7 is out, I'll update this.

@MultisampledNight MultisampledNight changed the title rare: 1.10.3 -> 1.10.6 rare: 1.10.3 -> 1.10.7 Dec 10, 2023
@MultisampledNight MultisampledNight marked this pull request as ready for review December 10, 2023 12:29
@WolfangAukang
Copy link
Contributor

Result of nixpkgs-review pr 272763 run on x86_64-linux 1

2 packages built:
  • rare
  • rare.dist

@WolfangAukang WolfangAukang added 12.approvals: 1 This PR was reviewed and approved by one reputable person 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package labels Dec 11, 2023
@delroth delroth added 12.approvals: 2 This PR was reviewed and approved by two reputable people and removed 12.approvals: 1 This PR was reviewed and approved by one reputable person labels Dec 11, 2023
@wegank wegank merged commit c4aaf5a into NixOS:master Dec 11, 2023
27 checks passed
@MultisampledNight MultisampledNight deleted the rare-1.10.6 branch December 11, 2023 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 12.approvals: 2 This PR was reviewed and approved by two reputable people 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants