Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

termineter: init at 1.0.4 #277125

Closed
wants to merge 3 commits into from
Closed

termineter: init at 1.0.4 #277125

wants to merge 3 commits into from

Conversation

t4ccer
Copy link
Member

@t4ccer t4ccer commented Dec 27, 2023 •
edited
Loading

Description of changes

Added termineter package and a couple of python dependencies

Tracked in #81418

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@t4ccer t4ccer changed the title python3Packages.crcelk: init at 1.3 termineter: init at 1.0.4 Dec 27, 2023
@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 labels Dec 27, 2023
WolfangAukang
WolfangAukang suggested changes Dec 27, 2023
View reviewed changes
Copy link
Contributor

@WolfangAukang WolfangAukang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible to build the libraries from source instead of Pypi? smoke-zephyr has tests.

pkgs/by-name/te/termineter/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/te/termineter/package.nix Show resolved Hide resolved
@t4ccer
Copy link
Member Author

t4ccer commented Dec 27, 2023

I've changed python sources to github, didn't realize that there is a difference and fetching from pypi won't fetch tests, thanks for catching that

@WolfangAukang
Copy link
Contributor

Result of nixpkgs-review pr 277125 run on x86_64-linux 1

10 packages built:
  • python310Packages.crcelk
  • python310Packages.crcelk.dist
  • python310Packages.smoke-zephyr
  • python310Packages.smoke-zephyr.dist
  • python311Packages.crcelk
  • python311Packages.crcelk.dist
  • python311Packages.smoke-zephyr
  • python311Packages.smoke-zephyr.dist
  • termineter
  • termineter.dist

@WolfangAukang WolfangAukang added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Dec 27, 2023
@quantenzitrone
Copy link
Contributor

Result of nixpkgs-review pr 277125 run on x86_64-linux 1

10 packages built:
  • python310Packages.crcelk
  • python310Packages.crcelk.dist
  • python310Packages.smoke-zephyr
  • python310Packages.smoke-zephyr.dist
  • python311Packages.crcelk
  • python311Packages.crcelk.dist
  • python311Packages.smoke-zephyr
  • python311Packages.smoke-zephyr.dist
  • termineter
  • termineter.dist

@delroth delroth added 12.approvals: 2 This PR was reviewed and approved by two reputable people and removed 12.approvals: 1 This PR was reviewed and approved by one reputable person labels Dec 28, 2023
@t4ccer t4ccer requested a review from fabaff December 31, 2023 12:59
@delroth delroth removed the 12.approvals: 2 This PR was reviewed and approved by two reputable people label Dec 31, 2023
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/3721

@wegank wegank added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jul 4, 2024
@wegank wegank added the 2.status: merge conflict This PR has merge conflicts with the target branch label Nov 1, 2024
@t4ccer
Copy link
Member Author

t4ccer commented Nov 1, 2024

Done in #348550

@t4ccer t4ccer closed this Nov 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@quantenzitrone quantenzitrone quantenzitrone approved these changes

@WolfangAukang WolfangAukang WolfangAukang approved these changes

@fabaff fabaff Awaiting requested review from fabaff

Assignees
No one assigned
Labels
2.status: merge conflict This PR has merge conflicts with the target branch 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md 6.topic: python 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@t4ccer @WolfangAukang @quantenzitrone @nixos-discourse @fabaff @delroth @wegank