-
-
Notifications
You must be signed in to change notification settings - Fork 14.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cargo-c: Fix cargoSha256 #123348
cargo-c: Fix cargoSha256 #123348
Conversation
Last touched by @primeos, but he removed himself as a maintainer… |
Result of 162 packages marked as broken and skipped:
8714 packages skipped due to time constraints:
3 packages built successfully:
Result of 110 packages marked as broken and skipped:
8975 packages skipped due to time constraints:
3 packages built successfully:
1 suggestion:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, I can confirm the new hash.
I guess this was either missed by #122016 or is caused by something else related to #121259 (I didn't take a closer look at what caused it in this case). Unfortunately those hashes aren't that stable but that should hopefully improve over time.
Edit: Need to temporarily convert this to a draft. I thought only rav1e
was using cargo-c
but it seems like that has changed (should still be only rav1e
and libheif
(which also causes much fewer rebuilds: #121886) maybe CI also counts packages that haven't been build on ; not sure why but this seems like some sort of CI "malfunction" (https://gist.github.com/GrahamcOfBorg/1e514ecff635ed44b6297281ca3d1e35 lots of Haskell rebuilds, etc.)).nixos-unstable
yet - which could be still high due to the recent staging-next
merge
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like this really cause a lot of rebuilds now (via rav1e -> libheif -> ...
) so this actually needs to target staging. In that case: Would you mind updating the version as well?: https://github.com/lu-zero/cargo-c/releases/tag/v0.8.1 (I can also take care of it if necessary)
Please do, if possible, this was just a drive-by contributions |
to see what breaks, and also to get NixOS/nixpkgs@5a923e5 which may allow us to use `rustc` from `nixpkgs` again (see #2519) Issues encountered: * [x] in nixpks, various `cargoSHA256` were wrong. (NixOS/nixpkgs#123522, NixOS/nixpkgs#123348, NixOS/nixpkgs#123349) * [x] Ocaml built with musl, used for static builds, is currently broken. Reported at NixOS/nixpkgs#124476. Found a possible fix, submitted at NixOS/nixpkgs#124498 and currently included in this branch. * [x] New ocamlformat version * [x] Running new formatter on these files * [x] The RTS fails to build or link the C files (`stddef.h` missing) This stuff was very hairy before, and that doesn’t get better :-( If I use the wrapped `wasm32-unknown-wasi-clang`, the build makes some progress, but then fails with https://bugs.llvm.org/show_bug.cgi?id=43393 (as it used to before, and then somehow we fixed that) In the end, surgically adding an include to `CLANG_FLAGS` works, it seems. * [x] Some upgraded tool produces new `names` subsections, presumably from this Wasm proposal: https://github.com/WebAssembly/extended-name-section/blob/master/proposals/extended-name-section/Overview.md Worked around by jumping over them, but otherwise ignoring them. Should be refined. * [x] Haskell code ought to be adjusted to latest GHC * [x] Bump the `niv` that we install into the shell (also because of Haskell changes) * [x] The darwin rebuild of `rustc` and `git` keeps timing out on hydra.
this failed to build on a machine without the main nix cache, so I noticed that this sha is stale.