Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rav1e: fix cargoSha256 #123522

Closed
wants to merge 2 commits into from
Closed

rav1e: fix cargoSha256 #123522

wants to merge 2 commits into from

Conversation

nomeata
Copy link
Contributor

@nomeata nomeata commented May 18, 2021

No description provided.

@nomeata nomeata mentioned this pull request May 18, 2021
9 tasks
@nomeata
Copy link
Contributor Author

nomeata commented May 19, 2021

@primeos, this package seems to be related to cargo-c which you recently touched. Care to look at this?

@primeos
Copy link
Member

primeos commented May 19, 2021

Will be fixed once 85f9682 lands in master but thanks for noticing this hash mismatch as well.

@primeos primeos closed this May 19, 2021
@nomeata nomeata deleted the joachim/rav1e-sha branch May 19, 2021 13:00
mergify bot pushed a commit to dfinity/motoko that referenced this pull request May 28, 2021
to see what breaks, and also to get
NixOS/nixpkgs@5a923e5
which may allow us to use `rustc` from `nixpkgs` again (see #2519)

Issues encountered:

 * [x] in nixpks, various `cargoSHA256` were wrong. (NixOS/nixpkgs#123522, NixOS/nixpkgs#123348, NixOS/nixpkgs#123349)

 * [x] Ocaml built with musl, used for static builds, is currently broken. 
        
    Reported at NixOS/nixpkgs#124476.

    Found a possible fix, submitted at NixOS/nixpkgs#124498 and currently included in this branch.
 * [x] New ocamlformat version
 * [x] Running new formatter on these files
 * [x] The RTS fails to build or link the C files (`stddef.h` missing)
    This stuff was very hairy before, and that doesn’t get better :-(

    If I use the wrapped `wasm32-unknown-wasi-clang`, the build makes some progress, but then fails with https://bugs.llvm.org/show_bug.cgi?id=43393 (as it used to before, and then somehow we fixed that)

    In the end, surgically adding an include to `CLANG_FLAGS` works, it seems.
 * [x] Some upgraded tool produces new `names` subsections, presumably from this Wasm proposal: https://github.com/WebAssembly/extended-name-section/blob/master/proposals/extended-name-section/Overview.md
   Worked around by jumping over them, but otherwise ignoring them. Should be refined.
 * [x] Haskell code ought to be adjusted to latest GHC
 * [x] Bump the `niv` that we install into the shell (also because of Haskell changes)
 * [x] The darwin rebuild of `rustc` and `git` keeps timing out on hydra.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants