-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use nixpkgs 21.05 #2532
Use nixpkgs 21.05 #2532
Conversation
to see what breaks, and also to get NixOS/nixpkgs@5a923e5 which may allow us to use `rustc` from `nixpkgs` again (see #2519)
This reverts commit d5e3399.
This PR does not affect the produced WebAssembly code. |
Claudio wants to test this, so don’t merge before. Might be nice if someone on OSX would test using the |
Hmm, my Mac exhibits the same failure mode as the
I have seen this happening on the |
I am surprised you have to build that at all - isn't it part of our nix cache by now? |
Testing it now... (just by running nix-shell - lemme know if you want more). |
Works for me! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved, but see suggestions for typos and issue filing
Co-authored-by: Claudio Russo <[email protected]>
in #2532 we added a patch related to static building of ocaml packages, submitted to nixpkgs as NixOS/nixpkgs#124498, but it was never merged upstream. Supposedly a patch from NixOS/nixpkgs#135619 fixes it as well (and maybe more properly). So let’s try that!
to see what breaks, and also to get
NixOS/nixpkgs@5a923e5
which may allow us to use
rustc
fromnixpkgs
again (see #2519)Issues encountered:
in nixpks, various
cargoSHA256
were wrong. (rav1e: fix cargoSha256 NixOS/nixpkgs#123522, cargo-c: Fix cargoSha256 NixOS/nixpkgs#123348, rust-bindgen: Update cargoSha256 NixOS/nixpkgs#123349)Ocaml built with musl, used for static builds, is currently broken.
Reported at pkgsMusl.ocamlPackages.ocaml: -r and -pie may not be used together NixOS/nixpkgs#124476.
Found a possible fix, submitted at pkgsMusl.ocamlPackages.ocaml: Disable pie hardening on musl NixOS/nixpkgs#124498 and currently included in this branch.
New ocamlformat version
Running new formatter on these files
The RTS fails to build or link the C files (
stddef.h
missing)This stuff was very hairy before, and that doesn’t get better :-(
If I use the wrapped
wasm32-unknown-wasi-clang
, the build makes some progress, but then fails with https://bugs.llvm.org/show_bug.cgi?id=43393 (as it used to before, and then somehow we fixed that)In the end, surgically adding an include to
CLANG_FLAGS
works, it seems.Some upgraded tool produces new
names
subsections, presumably from this Wasm proposal: https://github.com/WebAssembly/extended-name-section/blob/master/proposals/extended-name-section/Overview.mdWorked around by jumping over them, but otherwise ignoring them. Should be refined.
Haskell code ought to be adjusted to latest GHC
Bump the
niv
that we install into the shell (also because of Haskell changes)The darwin rebuild of
rustc
andgit
keeps timing out on hydra.