Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

22.05 Feature Freeze #167025

Closed
dasJ opened this issue Apr 3, 2022 · 60 comments
Closed

22.05 Feature Freeze #167025

dasJ opened this issue Apr 3, 2022 · 60 comments
Assignees
Labels
6.topic: release process Issues or PRs which are parts of the NixOS release process
Milestone

Comments

@dasJ
Copy link
Member

dasJ commented Apr 3, 2022

It's time for another feature freeze!

Let's clarify any blocking concerns for the 22.05 release in this thread, which will go live on May 30th.
Feature Freeze issue of th previous release: #140168
Release Schedule: #165792

Edit: I have crossed out subsystems that have responded that there are no blockers

Nix/nix-cli ecosystem: @Profpatsch @edolstra @grahamc @nbp
Mobile: @samueldr
NixOS Modules / internals: @Ericson2314 @infinisil @alyssais @roberth
NixOS tests: @tfc
Marketing: @garbas @tomberek
Docs: @ryantm
Release: @NixOS/nixos-release-managers
Darwin: @NixOS/darwin-maintainers

BEAM: @NixOS/beam @minijackson
C: @matthewbauer @Mic92
Coq: @CohenCyril @Zimmi48 @siraben @vbgl
Dhall: @Gabriel439 @ehmry
Emacs: @adisbladis
Vim/Neovim: @jonringer @softinio @teto
Go: @c00w @cstrahan @Frostman @kalbasit @Mic92 @orivej @rvolosatovs @zowoq
Haskell: @NixOS/haskell
Python: @FRidh @mweinelt @jonringer
Perl: @stigtsp
PHP: @NixOS/php @Ma27
Ruby: @marsam
Rust: @andir @LnL7 @Mic92 @zowoq
R: @bcdarwin @jbedo

Bazel: @mboes @marsam @uri-canva @avdv @olebedev @groodt @aherrmann @ylecornec
Blockchains: @mmahut @RaghavSood
Cinnamon: @mkg20001
DockerTools: @roberth @utdemir
GNOME: @NixOS/gnome @bobby285271 @dasj19 @maxeaubrey
Pantheon: @NixOS/pantheon
Podman: @NixOS/podman
PostgreSQL: @thoughtpolice
Qt / KDE: @NixOS/qt-kde
systemd: @NixOS/systemd

Everyone else: @NixOS/nixpkgs-committers @NixOS/release-engineers

If you think some subsystem/person/GitHub team should be added or removed for the next release, you can modify the list here.

No issue is too big or too small, but let's remember that we are all working on the project voluntarily in our free time here, so let's focus on the issues that can be realistically addressed by release time. Thanks everyone!

@dasJ dasJ added the 6.topic: release process Issues or PRs which are parts of the NixOS release process label Apr 3, 2022
@dasJ dasJ pinned this issue Apr 3, 2022
@dasJ
Copy link
Member Author

dasJ commented Apr 3, 2022

Additional mentions because GitHub seems to stop pinging after I pinged too many people:

Blockchains: @mmahut @RaghavSood
Cinnamon: @mkg20001
DockerTools: @roberth @utdemir
GNOME: @bobby285271 @dasj19 @maxeaubrey
PostgreSQL: @thoughtpolice

@nixos-discourse
Copy link

This issue has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/22-05-feature-freeze/18453/1

@DianaOlympos
Copy link
Contributor

For @NixOS/beam i do not think we have anything that could be blocking on the docket.

@peterhoeg
Copy link
Member

peterhoeg commented Apr 3, 2022 via email

@dasJ
Copy link
Member Author

dasJ commented Apr 3, 2022

@peterhoeg Thanks, I added them to the Blockers project. If you want to add the team to the next announcement, you can just set the featureFreezePing flag in the list :)

@ryantm
Copy link
Member

ryantm commented Apr 3, 2022

I'm not really up on what is going on with the docs themselves, but I'm not aware of anything blocking the technical aspect of generating the docs. I don't have much to report on progress with generating the docs either. mmdoc is now packaged in nixpkgs, but it still needs more work to be a polished solution.

@bobby285271
Copy link
Member

No blockers for @NixOS/Pantheon, we are already shipping the latest Pantheon 6.1 and Pantheon 7 is not likely to happen in this release due to upstream delay.

@mweinelt mweinelt added this to the 22.05 milestone Apr 3, 2022
@teto
Copy link
Member

teto commented Apr 3, 2022

since I've noticed you started crossing topics:

  • no blocker for the lua ecosystem
  • for (neo)vim, there will be a neovim release in 2 weeks and I would like to merge update.py: updater vim updater #166941 . None should be an issue though, I've already updated the required dependencies for neovim master

@etu
Copy link
Contributor

etu commented Apr 3, 2022

No blocker for PHP as far as I know :)

@drupol
Copy link
Contributor

drupol commented Apr 3, 2022

No blocker for PHP as far as I know :)

I think we should tackle this at the next version: #154774

@mweinelt
Copy link
Member

mweinelt commented Apr 3, 2022

Python is currently in a good state. We're doing regular package set updates and have one more cycle in #166489 that we'll hopefully get into the next staging cycle.

PyPy3 currently fails to build due to a regression after the zlib update. #167115

@etu
Copy link
Contributor

etu commented Apr 3, 2022

No blocker for PHP as far as I know :)

I think we should tackle this at the next version: #154774

For sure, but we're too close to a release for that. We can do that right after branchoff which isn't relevant for this thread.

@SomeoneSerge
Copy link
Contributor

On behalf of the newly created @NixOS/cuda-maintainers, we're finishing an important major bump (cudnn 7.6 -> 8.3, cuda 10.1 -> 11.4) that we'd like to get into the release. There are a few failing packages that hadn't been tested with CUDA until now, that we would like to meet the release in an already fixed state: #167068

P.S. Keep in mind we're just getting acquainted with the release process:)

@jtojnar
Copy link
Member

jtojnar commented Apr 3, 2022

For GNOME, we will want to include

And there are still some annoying regression. For some of them, we expect them to be fixed in GNOME 42.1 (April 23).


For docs, we want:

@roberth
Copy link
Member

roberth commented Apr 3, 2022

  • NixOS module system: no blocking issues.
    Infinisil and I have made some quality of life improvements that have been merged for some time. We'll take it easy until branch-off, as far as I'm concerned.

  • dockerTools: also no blocking issues.

@Gabriella439
Copy link
Contributor

No blocking issues for Dhall

@mweinelt
Copy link
Member

mweinelt commented Apr 4, 2022

The hydra package is currently failing to build which should be considered a blocker. Mostly expecting #160202 to get finished.

@jbedo
Copy link
Contributor

jbedo commented Apr 4, 2022

No blockers for R

@bhankas
Copy link
Contributor

bhankas commented Apr 4, 2022

Emacs 28.1 was released yesterday.

Announcement: https://lists.gnu.org/archive/html/emacs-devel/2022-04/msg00093.html
Release tar: https://git.savannah.gnu.org/cgit/emacs.git/snapshot/emacs-28.1.tar.gz

Perhaps @adisbladis can comment on requirement to be in the release.

@tfc
Copy link
Contributor

tfc commented Apr 5, 2022

No blockers for the integration test driver

@Synthetica9
Copy link
Member

I'd really like to get #158175 fixed, but I'm not sure how feasible that is

@totoroot totoroot mentioned this issue Apr 5, 2022
13 tasks
@vcunat
Copy link
Member

vcunat commented Apr 15, 2022

They sound like bugs, maybe the fixes will be quite simple. Overall I find it unlikely that the feature freeze applies there, with fixes hopefully possible to backport at any later point.

@Madouura
Copy link
Contributor

We should probably ensure that #168303 is in 22.05, as it's a blocker for cross-compilation, in my case riscv64.

@mweinelt
Copy link
Member

We should probably ensure that #168303 is in 22.05, as it's a blocker for cross-compilation, in my case riscv64.

Already part of #168737.

@adisbladis
Copy link
Member

Regarding Emacs:
Emacs 28 was merged in #168076 which is great timing for the release. No blockers.

@siraben
Copy link
Member

siraben commented Apr 22, 2022

@CohenCyril @vbgl @Zimmi48 should we update the default version of Coq to the latest version (8.15)? No other blockers AFAIK.

@vbgl
Copy link
Contributor

vbgl commented Apr 22, 2022

Yes. I’m working on it.

@adisbladis
Copy link
Member

Enabling both libcontainer based software such as runc/podman and NixOS containers have been broken for years (#77925) and is fixed by moving configuration/state directories.

This is addressed by #87268 which should go in 22.05.

@jaen
Copy link
Contributor

jaen commented Apr 28, 2022

Apologies in advance if this is the wrong place to talk about this (whether this is considered a breaking change or a release-worthy topic) as I never participated in a release, but maybe it would be useful to get #170655 in? At least for me I couldn't get VAAPI working in Brave without those changes, so it might be useful for other people to have this working OOtB in 22.05?

@mweinelt
Copy link
Member

mweinelt commented Apr 28, 2022

Java/OpenJDK is pretty much unmaintained. We don't have OpenJDK 18. We do Have 17, 11 and 8 (all LTS). But we also Have 16, 15, 14, 13, 12.

#170825

@edwtjo @asbachb

@primeos
Copy link
Member

primeos commented Apr 30, 2022

We could also really need additional LLVM maintainers as we barely manage to keep things up-to-date and working.
I finally opened a dedicated issue regarding that (this was long overdue): #171047
(Sorry for hijacking this issue but this seems relevant in general (LLVM is a release critical package, llvmPackages_latest will already be outdated for 22.05 (#165701), and it will probably be worse for the next stable release if we don't find additional maintainers.)

@Madouura
Copy link
Contributor

Madouura commented May 1, 2022

I know we're already in the 3rd stage of the release schedule, but I would highly recommend we include these commits in 22.05, even if potentially breaking.

The GCC one is just a bugfix update, so should be fine, using GCC11 as default for riscv could potentially lead to unexpected behavior.
That said, it seems to only fix cross compiling and native compiling without side-effects from my own tests.

@vcunat
Copy link
Member

vcunat commented May 1, 2022

These will be included. The minor update wouldn't be considered breaking anyway. Support for riscv in NixPkgs is... experimental?, so I think there it's fine. (Though I'm a bit doubtful about which riscv users will use stable?)

@SomeoneSerge
Copy link
Contributor

A silly question: we branch off master, things that are now in master are included?

@ulrikstrid
Copy link
Member

Does this need to be fixed before? #170897

@rnhmjoj
Copy link
Contributor

rnhmjoj commented May 1, 2022

A silly question: we branch off master, things that are now in master are included?

I think so: according to the release schedule, the branch off is supposed to occur on May 22.

@0x4A6F
Copy link
Member

0x4A6F commented May 1, 2022

#73404 is blocking installation if config.boot.initrd.secrets is set.

@nrdxp

This comment was marked as off-topic.

@jaen

This comment was marked as off-topic.

@rnhmjoj
Copy link
Contributor

rnhmjoj commented May 2, 2022

I have a strange "not a git repo" error if I call sudo nixos-rebuild

See #169193

@jtojnar
Copy link
Member

jtojnar commented May 2, 2022

Regarding GNOME, there two more potentially problematic changes:

  • adwaita-icon-theme removed majority of non-symbolic (colour) icons, which can make apps look inconsistent and in the worst case even make them unusable or crash (so far I have only encountered that in Meld). Probably something to note into ZHF.

  • webkitgtk 3.36.0 does not render HTML on some systems e.g. in Evolution, gnucash, we need to check if 3.36.1 fixes that. Though that update breaks tests of liferea. And there is also this issue, which might require us to switch back to wpe renderer. I would really appreciate if someone could help with webkitgtk maintenance, as I currently lack time for that.

@kjeremy

This comment was marked as off-topic.

@dasJ
Copy link
Member Author

dasJ commented May 2, 2022

Since a lot of people are (probably) subscribed to this issue due to @NixOS/nixpkgs-committers being pinged, I'd prefer this issue to only have a minimal conversation.
This conversation should be about what issues may or should be blocking the release, issue-specific topics should be discussed in the respective issues/pull requests.

Now about some of these comments:

This comment is my judgement on how blocking these issues are to the release. If you disagree with me, feel free to ping me in the respective issues to continue the discussion there rather than here.
Also, not being critical to the release does not mean I think these issues are not important. Something to consider is that we have a very well working backport wokflow now and some issues can be fixed during the release (like the documentation).

@NorfairKing
Copy link
Contributor

I would love to get a new stack release into nixos 22.05: commercialhaskell/stack#5733 :D

@ners
Copy link
Member

ners commented May 16, 2022

I would love to get 22.05 ISOs VM-friendly, but it seems stuck in merge limbo: #172668

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: release process Issues or PRs which are parts of the NixOS release process
Projects
None yet
Development

No branches or pull requests