Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gnome.gnome-shell: 42.0 → 42.1 #171904

Merged
merged 3 commits into from
May 7, 2022
Merged

gnome.gnome-shell: 42.0 → 42.1 #171904

merged 3 commits into from
May 7, 2022

Conversation

jtojnar
Copy link
Member

@jtojnar jtojnar commented May 7, 2022 •
edited by bobby285271
Loading

Description of changes

Verified that it:

  • Fixes GNOME Shell crash when closing a window on Activities view.
Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
    • Successfully logged into a VM and opened and closed some apps
    • nixosTests.gnome
    • nixosTests.gnome-xorg
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.05 Release Notes (or backporting 21.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

Closes #171905
Closes #171906
Closes #171908

@jtojnar jtojnar requested a review from hedning as a code owner May 7, 2022 03:29
@github-actions github-actions bot added the 6.topic: GNOME GNOME desktop environment and its underlying platform label May 7, 2022
@jtojnar
Copy link
Member Author

jtojnar commented May 7, 2022

@ofborg test gnome gnome-xorg

This was referenced May 7, 2022
Closed
Closed
@ofborg ofborg bot requested review from bobby285271, amaxine and dasj19 May 7, 2022 03:44
@ofborg ofborg bot added 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 1-10 10.rebuild-linux: 11-100 labels May 7, 2022
@jtojnar jtojnar merged commit 17b0f14 into NixOS:master May 7, 2022
@jtojnar jtojnar deleted the gnome-updates branch May 7, 2022 09:39
@jtojnar jtojnar mentioned this pull request May 11, 2022
Closed
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amaxine amaxine amaxine approved these changes

@hedning hedning Awaiting requested review from hedning

@bobby285271 bobby285271 Awaiting requested review from bobby285271

@dasj19 dasj19 Awaiting requested review from dasj19

Assignees
No one assigned
Labels
6.topic: GNOME GNOME desktop environment and its underlying platform 10.rebuild-darwin: 1-10 10.rebuild-linux: 11-100 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jtojnar @amaxine