Installing any libcontainer related software (runc, podman, cri-o) bricks nixos-container

[arianvp]

Describe the bug
NixOS Containers expect /etc/containers to be used by it. but this is a directory that is used by libcontainer-compatible systems like podman. More specifically it creates a file /etc/containers/registries.conf

nixos-container.pl then hard-crashes as it expects its own *.conf files to live there on the following line:

nixpkgs/pkgs/tools/virtualization/nixos-container/nixos-container.pl

Line 153 in a0a3f5c

foreach my $confFile2 (glob "/etc/containers/*.conf") {

but that file but it dies instead

To Reproduce
Install something libcontainer-y and use it
nixos-container is now broken

Expected behavior
nixos-container should not namesquat /etc/containers

Screenshots
If applicable, add screenshots to help explain your problem.

Additional context
Add any other context about the problem here.

Metadata
Please run nix-shell -p nix-info --run "nix-info -m" and paste the result.

Maintainer information:

# a list of nixpkgs attributes affected by the problem
attribute:
# a list of nixos modules affected by the problem
module:

[stale]

Hello, I'm a bot and I thank you in the name of the community for opening this issue.

To help our human contributors focus on the most-relevant reports, I check up on old issues to see if they're still relevant. This issue has had no activity for 180 days, and so I marked it as stale, but you can rest assured it will never be closed by a non-human.

The community would appreciate your effort in checking if the issue is still valid. If it isn't, please close it.

If the issue persists, and you'd like to remove the stale label, you simply need to leave a comment. Your comment can be as simple as "still important to me". If you'd like it to get more attention, you can ask for help by searching for maintainers and people that previously touched related code and @ mention them in a comment. You can use Git blame or GitHub's web interface on the relevant files to find them.

Lastly, you can always ask for help at our Discourse Forum or at #nixos' IRC channel.

[arianvp]

Not stale. Still extremely relevant.

…

On Wed, Jul 15, 2020, 20:49 stale[bot] ***@***.***> wrote: Hello, I'm a bot and I thank you in the name of the community for opening this issue. To help our human contributors focus on the most-relevant reports, I check up on old issues to see if they're still relevant. This issue has had no activity for 180 days, and so I marked it as stale, but you can rest assured it will never be closed by a non-human. The community would appreciate your effort in checking if the issue is still valid. If it isn't, please close it. If the issue persists, and you'd like to remove the stale label, you simply need to leave a comment. Your comment can be as simple as "still important to me". If you'd like it to get more attention, you can ask for help by searching for maintainers and people that previously touched related code and @ mention them in a comment. You can use Git blame <https://git-scm.com/docs/git-blame> or GitHub's web interface <https://docs.github.com/en/github/managing-files-in-a-repository/tracking-changes-in-a-file> on the relevant files to find them. Lastly, you can always ask for help at our Discourse Forum <https://discourse.nixos.org/> or at #nixos' IRC channel <https://webchat.freenode.net/#nixos>. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#77925 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAEZNI4C5F2H6I75S5XP6D3R3X23FANCNFSM4KIJAPKA> .

[stale]

I marked this as stale due to inactivity. → More info

[arianvp]

Not stale

[puffnfresh]

Moving this to /etc/nixos/containers makes more sense to me.

[stale]

I marked this as stale due to inactivity. → More info

[arianvp]

Not stale

[adisbladis]

I have touched up #87268 which fixes this. PTAL.