Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

meld: Fix view not rendering with adwaita-icon-theme 42 due to removed icons #171273

Merged
merged 1 commit into from
May 5, 2022
Merged

meld: Fix view not rendering with adwaita-icon-theme 42 due to removed icons #171273

merged 1 commit into from
May 5, 2022

Conversation

jtojnar
Copy link
Member

@jtojnar jtojnar commented May 2, 2022

Description of changes
Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.05 Release Notes (or backporting 21.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@jtojnar jtojnar added this to the 22.05 milestone May 2, 2022
@ofborg ofborg bot requested a review from mimame May 2, 2022 15:46
@ofborg ofborg bot added 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 labels May 2, 2022
@jtojnar jtojnar mentioned this pull request May 2, 2022
Closed
@jtojnar jtojnar merged commit 1e7cc37 into NixOS:master May 5, 2022
@jtojnar jtojnar deleted the meld-fix branch May 5, 2022 22:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mimame mimame Awaiting requested review from mimame

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Milestone
22.05
Development

Successfully merging this pull request may close these issues.
1 participant
@jtojnar