-
Notifications
You must be signed in to change notification settings - Fork 236
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEA] collect_set on struct[Array] #5508
Comments
|
Depends on rapidsai/cudf#10870 |
A note for cudf implementation: The current cudf unit tests for |
Now depends on: which in turn depends on: |
…inct` (#11228) The current groupby/reducttion `collect_set` aggregations use `lists::drop_list_duplicates` to generate set(s) of distinct elements. This PR changes that to use `cudf::distinct` and `cudf::lists::distinct` instead, which have some advantages including: * Fully supporting nested types, and: * Achieving better performance (`O(n)` instead of `O(nlogn)`) by internally using hash table instead of segmented sort. This also enables nested types support for `collect_set` in spark-rapids (issue NVIDIA/spark-rapids#5508). The changes in Java code here are only to fix unit tests. Previously, they were implemented with the assumption that the `collect_set` results are sorted, now they fail when the results are no longer sorted. Authors: - Nghia Truong (https://github.com/ttnghia) Approvers: - Jason Lowe (https://github.com/jlowe) - David Wendt (https://github.com/davidwendt) - MithunR (https://github.com/mythrocks) URL: #11228
Fixed via #6079 |
I wish collect_set can support struct[Array] as input column.
The ask is mainly for struct[Array(String)] and struct[Array(Long)].
For example:
The not-supported-messages:
The text was updated successfully, but these errors were encountered: