Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEA] Fully support nested types in lists::drop_list_duplicates #11093

Closed
ttnghia opened this issue Jun 10, 2022 · 1 comment · Fixed by #11236
Closed

[FEA] Fully support nested types in lists::drop_list_duplicates #11093

ttnghia opened this issue Jun 10, 2022 · 1 comment · Fixed by #11236
Assignees
@ttnghia
Labels
feature request New feature or request libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change Spark Functionality that helps Spark RAPIDS

Comments

@ttnghia
Copy link
Contributor

ttnghia commented Jun 10, 2022

Currently lists::drop_lists_duplicates can only handle input data of basic types and structs of basic types. As requested by customer(s) (NVIDIA/spark-rapids#5508), we should add full support for nested types into it.
@ttnghia ttnghia added feature request New feature or request Needs Triage Need team to review and classify labels Jun 10, 2022
@ttnghia ttnghia mentioned this issue Jun 10, 2022
Closed
@ttnghia ttnghia self-assigned this Jun 15, 2022
@ttnghia ttnghia added libcudf Affects libcudf (C++/CUDA) code. Spark Functionality that helps Spark RAPIDS non-breaking Non-breaking change and removed Needs Triage Need team to review and classify labels Jun 15, 2022
@ttnghia ttnghia mentioned this issue Jun 21, 2022
Merged
@HaoYang670 HaoYang670 mentioned this issue Jun 26, 2022
Closed
2 tasks
@sameerz
Copy link
Contributor

sameerz commented Jul 8, 2022

Depends on #11053

This was referenced Jul 8, 2022
Closed
Merged
@ttnghia ttnghia linked a pull request Jul 14, 2022 that will close this issue
Remove lists::drop_list_duplicates #11236
Merged
rapids-bot bot pushed a commit that referenced this issue Jul 22, 2022
@ttnghia
Remove lists::drop_list_duplicates (#11236)
a541ffb 
This PR completely removes `cudf::lists::drop_list_duplicates`. It is replaced by the new API `cudf::list::distinct` which has a simpler implementation but better performance. The replacements for internal cudf usage have all been merged before thus there is no side effect or breaking for the existing APIs in this work.

Closes #11114, #11093, #11053, #11034, and closes #9257.

Depends on:
 * #11228
 * #11149
 * #11234
 * #11233

Authors:
  - Nghia Truong (https://github.com/ttnghia)

Approvers:
  - Jordan Jacobelli (https://github.com/Ethyling)
  - Robert Maynard (https://github.com/robertmaynard)
  - Vukasin Milovanovic (https://github.com/vuule)
  - Bradley Dice (https://github.com/bdice)

URL: #11236
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ttnghia ttnghia

Labels
feature request New feature or request libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change Spark Functionality that helps Spark RAPIDS
Projects
None yet
Milestone
No milestone
2 participants
@sameerz @ttnghia