-
Notifications
You must be signed in to change notification settings - Fork 908
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fully support nested types in lists::drop_list_duplicates
#11224
Closed
ttnghia
wants to merge
31
commits into
rapidsai:branch-22.08
from
ttnghia:reimplement_drop_list_duplicates
Closed
Fully support nested types in lists::drop_list_duplicates
#11224
ttnghia
wants to merge
31
commits into
rapidsai:branch-22.08
from
ttnghia:reimplement_drop_list_duplicates
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ttnghia
added
feature request
New feature or request
2 - In Progress
Currently a work in progress
libcudf
Affects libcudf (C++/CUDA) code.
Spark
Functionality that helps Spark RAPIDS
non-breaking
Non-breaking change
labels
Jul 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
2 - In Progress
Currently a work in progress
CMake
CMake build issue
feature request
New feature or request
libcudf
Affects libcudf (C++/CUDA) code.
non-breaking
Non-breaking change
Spark
Functionality that helps Spark RAPIDS
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reimplements
lists::drop_list_duplicates
, adding full support for nested types. The new implementation is significantly shorter than the old one by leveraging the existinglabel_segments
andstable_distinct
utilities APIs. Performance should also be improved significantly by completely avoiding sorting.Closes #11093, closes #11053, and closes #9257.
Depends on:
lists::distinct
andcudf::detail::stable_distinct
#11149Follow up work:
lists::drop_list_duplicates
#11114Progress: