Add missing Thrust includes. #161
Conversation
PointKernel
added
type: feature request
|
I checked the logs and the new thrust was used: All CI passed for commit 97044cc. Next: wait for final Thrust 1.17.0 release, retest, then revert commits altering rapids-cmake behavior. Then this can be merged. We can update rapids-cmake once all repos are ready. |
|
@bdice Thanks! Any ETA for the thrust upgrade in |
|
The upstream change in rapids-cmake is probably a week away from ready. The Thrust 1.17.0 release should come out next week, and we'll need to finalize some testing across all RAPIDS repos. This PR's changes to edit: It's ready for review 🚀 Tracking PR for rapids-cmake: rapidsai/rapids-cmake#199 |
This reverts commit 97044cc.
Depends on NVIDIA/cuCollections#165 and NVIDIA/cuCollections#171 This is a preparation step to finally address #10841. It fetches the latest version of `cuco` that [adds missing thrust headers ](NVIDIA/cuCollections#161) and [improves `static_map::retrieve_all`](NVIDIA/cuCollections#169). Authors: - Yunsong Wang (https://github.com/PointKernel) Approvers: - Bradley Dice (https://github.com/bdice) - Vyas Ramasubramani (https://github.com/vyasr) URL: #10983
Closes #146
Description
This PR cleans up some
#includes for Thrust. This is meant to help ease the transition to Thrust 1.16 / 1.17 when that is updated in rapids-cmake.(I'm going to test this locally with Thrust 1.16 and will open the draft PR once I confirm it works.)
Context
Version 1.16 of Thrust reduced the number of internal header inclusions:
I am making similar changes across all RAPIDS libraries to clean up includes ("include what we use," in essence) to make sure we have compatibility with future versions of Thrust.